Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49040

Grader report grade feedback is truncated in AJAX mode if the comment contains "& "

    XMLWordPrintable

Details

    • MOODLE_27_STABLE, MOODLE_33_STABLE
    • MOODLE_32_STABLE, MOODLE_33_STABLE
    • MDL-49040-master
    • Hide
      1. Create a course.
      2. Enrol two students.
      3. Add an assignment activity.
      4. Go to gradebook.
      5. Go to Setup / Preferences: Grader report.
      6. Set "Show quick feedback" to Yes.
      7. Set "Enable AJAX" to Yes.
      8. Go back to gradebook (grader report).
      9. Click Turn editing on button.
      10. Type "Test comment 1 2 & 3 4"
      11. Click Turn editing off button.
      12. Click Turn editing on button again.

      Before the patch: Only Test comment 1 2 is saved. "& 3 4" is truncated.

      Expected result: The comment should be Test comment 1 2 & 3 4".

      Show
      Create a course. Enrol two students. Add an assignment activity. Go to gradebook. Go to Setup / Preferences: Grader report. Set "Show quick feedback" to Yes. Set "Enable AJAX" to Yes. Go back to gradebook (grader report). Click Turn editing on button. Type "Test comment 1 2 & 3 4" Click Turn editing off button. Click Turn editing on button again. Before the patch: Only Test comment 1 2 is saved. "& 3 4" is truncated. Expected result: The comment should be Test comment 1 2 & 3 4".

    Description

      To reproduce you need to first go to the grader report settings, enable AJAX editing and "Show quick feedback".

      If a user goes to the grade report and enters a comment on a gradebook item, and that comment contains the string "& ", everything that comes after the string will be truncated in the gradebook.

      For example, if the instructor enters the text "Check Strunk & White for more information," in the blank next to the grade the comment would be truncated to "Check Strunk ".

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36756 In grader report, some characters are stripped from the quick feedback field

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              jebarvia Joshua Ebarvia
              rloconne Rebecca O'Connell
              Marcus Green Marcus Green
              Dan Poltawski Dan Poltawski
              Adrian Greeve Adrian Greeve
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                10/Jul/17