Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49040

Grader report grade feedback is truncated in AJAX mode if the comment contains "& "

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a course.
      2. Enrol two students.
      3. Add an assignment activity.
      4. Go to gradebook.
      5. Go to Setup / Preferences: Grader report.
      6. Set "Show quick feedback" to Yes.
      7. Set "Enable AJAX" to Yes.
      8. Go back to gradebook (grader report).
      9. Click Turn editing on button.
      10. Type "Test comment 1 2 & 3 4"
      11. Click Turn editing off button.
      12. Click Turn editing on button again.

      Before the patch: Only Test comment 1 2 is saved. "& 3 4" is truncated.

      Expected result: The comment should be Test comment 1 2 & 3 4".

      Show
      Create a course. Enrol two students. Add an assignment activity. Go to gradebook. Go to Setup / Preferences: Grader report. Set "Show quick feedback" to Yes. Set "Enable AJAX" to Yes. Go back to gradebook (grader report). Click Turn editing on button. Type "Test comment 1 2 & 3 4" Click Turn editing off button. Click Turn editing on button again. Before the patch: Only Test comment 1 2 is saved. "& 3 4" is truncated. Expected result: The comment should be Test comment 1 2 & 3 4".
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE
    • Pull Master Branch:
      MDL-49040-master

      Description

      To reproduce you need to first go to the grader report settings, enable AJAX editing and "Show quick feedback".

      If a user goes to the grade report and enters a comment on a gradebook item, and that comment contains the string "& ", everything that comes after the string will be truncated in the gradebook.

      For example, if the instructor enters the text "Check Strunk & White for more information," in the blank next to the grade the comment would be truncated to "Check Strunk ".

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jebarvia Joshua Ebarvia
              Reporter:
              rloconne Rebecca O'Connell
              Peer reviewer:
              Marcus Green
              Integrator:
              Dan Poltawski
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Jul/17