[MDL-49052] Incorrect headings for upcoming events pages - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.7.5, 2.8.3
Fix Version/s: 2.9
Component/s: Accessibility, Calendar
Labels:

Testing Instructions:
Hide

At all times, confirm that there is a heading on the calendar pages (I used calendar, but I'm happy for other suggestions).

When there are no events in the future:

On /calendar/view.php and confirm that the text "no upcoming events" is not in a heading tag.

On a single day view where there are no events, the text "There are no events this day." is not in a heading tag

When there are events on the calendar, confirm that the only change is the page heading
Show
At all times, confirm that there is a heading on the calendar pages (I used calendar, but I'm happy for other suggestions). When there are no events in the future: On /calendar/view.php and confirm that the text "no upcoming events" is not in a heading tag. On a single day view where there are no events, the text "There are no events this day." is not in a heading tag When there are events on the calendar, confirm that the only change is the page heading
Affected Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Fixed Branches:
MOODLE_29_STABLE
Pull from Repository:
https://github.com/totara/moodle.git
Pull Master Branch:
m29_~~MDL-49052~~
Pull Master Diff URL:
https://github.com/totara/moodle/compare/m29_MDL-49052

Description

When on the upcoming events page (/calendar/view.php) there is a gap in the headings (from h1 to h3) and if there are no results the user is told with a h3 (which isn't an appropriate use of headings)

Attachments

Activity

People

Assignee:: Brian Barnes

Reporter:: Brian Barnes

Peer reviewer:: David Monllaó

Integrator:: Dan Poltawski

Tester:: Damyon Wiese

Participants:: Brian Barnes, CiBoT, Damyon Wiese, Dan Poltawski, David Monllaó, Marina Glancy, Mary Cooch

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 02/Feb/15 2:42 PM

Updated:: 05/May/15 2:54 AM

Resolved:: 13/Feb/15 1:35 AM

Fix Release Date:: 11/May/15