Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49052

Incorrect headings for upcoming events pages

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      At all times, confirm that there is a heading on the calendar pages (I used calendar, but I'm happy for other suggestions).

      When there are no events in the future:

      • On /calendar/view.php and confirm that the text "no upcoming events" is not in a heading tag.
      • On a single day view where there are no events, the text "There are no events this day." is not in a heading tag
      • When there are events on the calendar, confirm that the only change is the page heading
      Show
      At all times, confirm that there is a heading on the calendar pages (I used calendar, but I'm happy for other suggestions). When there are no events in the future: On /calendar/view.php and confirm that the text "no upcoming events" is not in a heading tag. On a single day view where there are no events, the text "There are no events this day." is not in a heading tag When there are events on the calendar, confirm that the only change is the page heading
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      m29_MDL-49052
    • Pull Master Diff URL:

      Description

      When on the upcoming events page (/calendar/view.php) there is a gap in the headings (from h1 to h3) and if there are no results the user is told with a h3 (which isn't an appropriate use of headings)

        Attachments

          Activity

            People

            Assignee:
            brianb Brian Barnes
            Reporter:
            brianb Brian Barnes
            Peer reviewer:
            David Monllaó David Monllaó
            Integrator:
            Dan Poltawski Dan Poltawski
            Tester:
            Damyon Wiese Damyon Wiese
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/May/15