Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49054

Remove SCORM 2004 debugging code

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.5
    • Fix Version/s: 2.9
    • Component/s: SCORM
    • Testing Instructions:
      Hide

      Testing/peer review for this is mostly code-based. It removes some very old debugging output that is hard to trigger as we don't officially support packages that will trigger this code. (SCORM 2004)

      It should be sufficient to test a normal SCORM 1.2 package and make sure it saves learner data.

      Show
      Testing/peer review for this is mostly code-based. It removes some very old debugging output that is hard to trigger as we don't officially support packages that will trigger this code. (SCORM 2004) It should be sufficient to test a normal SCORM 1.2 package and make sure it saves learner data.
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull Master Branch:
      master_MDL-49054

      Description

      Matteo found some debugging code in a SCORM 2004 related method, https://github.com/moodle/moodle/blob/e435f174d3988785ebe8bd6a23e5aa2df91c16d6/mod/scorm/locallib.php#L498:

       ob_start();
      $filepath = $CFG->dataroot."\\temp\\tempfile.txt";
      $fh = fopen($filepath, "a+");
      var_dump($track);
      $string = ob_get_clean();
      fwrite($fh, $string);
      fclose($fh);
      

      We should probably remove this or make a concious decision to ignore it as it's part of the SCORM 2004 code.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              danmarsden Dan Marsden
              Reporter:
              danmarsden Dan Marsden
              Integrator:
              Dan Poltawski
              Tester:
              Andrew Nicols
              Participants:
              Component watchers:
              Damyon Wiese, Dan Marsden, Matteo Scaramuccia, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15