Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49054

Remove SCORM 2004 debugging code

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.7.5
    • 2.9
    • SCORM
    • MOODLE_27_STABLE
    • MOODLE_29_STABLE
    • master_MDL-49054
    • Hide

      Testing/peer review for this is mostly code-based. It removes some very old debugging output that is hard to trigger as we don't officially support packages that will trigger this code. (SCORM 2004)

      It should be sufficient to test a normal SCORM 1.2 package and make sure it saves learner data.

      Show
      Testing/peer review for this is mostly code-based. It removes some very old debugging output that is hard to trigger as we don't officially support packages that will trigger this code. (SCORM 2004) It should be sufficient to test a normal SCORM 1.2 package and make sure it saves learner data.

    Description

      Matteo found some debugging code in a SCORM 2004 related method, https://github.com/moodle/moodle/blob/e435f174d3988785ebe8bd6a23e5aa2df91c16d6/mod/scorm/locallib.php#L498:

       ob_start();
      $filepath = $CFG->dataroot."\\temp\\tempfile.txt";
      $fh = fopen($filepath, "a+");
      var_dump($track);
      $string = ob_get_clean();
      fwrite($fh, $string);
      fclose($fh);
      

      We should probably remove this or make a concious decision to ignore it as it's part of the SCORM 2004 code.

      Attachments

        Issue Links

          Activity

            People

              danmarsden Dan Marsden
              danmarsden Dan Marsden
              Dan Poltawski Dan Poltawski
              Andrew Lyons Andrew Lyons
              Dan Marsden, Matteo Scaramuccia, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/May/15