Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49061

Multi-language feature doesn't work on the Activity Completion Report within a course

    Details

    • Testing Instructions:
      Hide

      1. Enable multilang filter for contents and headings

      2. Enable completion

      3. In the course with the enrolled students: Create activity with completion, use long multilang name with quotes, for example

      <span class="multilang" lang="en">Very long activity "title" in English and it goes on</span><span class="multilang" lang="ru">Очень длинное "название" активности на русском и все длиннее и длиннее</span>
      

      4. Open progress report (activity completion), view it in both languages. Make sure activity name is displayed correctly in:

      • header (shortened)
      • title for the icon (full)
      • hint for each student in the column (full)
      • when exporting to csv (full, in two columns), try both exporting formats

      5. Open course completion settings. Inspect the page in both languages and make sure that activity name and type are displayed correctly.

      6. Select the checkbox next to activity name and save the form

      7. Open "Course completion" report, inspect it in both languages, make sure that activity name is displayed correctly in:

      • header (shortened)
      • icon title (full)
      • as hint for checkboxes in the column (full)
      • in both export formats (full)
      Show
      1. Enable multilang filter for contents and headings 2. Enable completion 3. In the course with the enrolled students: Create activity with completion, use long multilang name with quotes, for example <span class= "multilang" lang= "en" >Very long activity "title" in English and it goes on</span><span class= "multilang" lang= "ru" >Очень длинное "название" активности на русском и все длиннее и длиннее</span> 4. Open progress report (activity completion), view it in both languages. Make sure activity name is displayed correctly in: header (shortened) title for the icon (full) hint for each student in the column (full) when exporting to csv (full, in two columns), try both exporting formats 5. Open course completion settings. Inspect the page in both languages and make sure that activity name and type are displayed correctly. 6. Select the checkbox next to activity name and save the form 7. Open "Course completion" report, inspect it in both languages, make sure that activity name is displayed correctly in: header (shortened) icon title (full) as hint for checkboxes in the column (full) in both export formats (full)
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull Master Branch:
      wip-MDL-49061-master

      Description

      Hello.

      We've had the below multi-language issue reported by a client -

      We have noticed the multi-language feature doesn't work on the Activity Completion Report within a course (Course Administration>Report>Activity Completion), as it messes up the HTML code.

      It seems that moodle wishes to add the activity title onto a title attribute of an <a> tag, but because the activity ttle includes html code:
      <span class=”multilang” lang=”en” >TITLE</span><span class=”multilang” lang=”cy” >WELSH TITLE</span>
      The generated code becomes:
      <a href=”…..” title=”<span class=”multilang” lang=”en” >TITLE</span><span class=”multilang” lang=”cy” >WELSH TITLE</span>”>…</a>
      Which plays havoc with the browser’s interpretation of the html.

      To recreate the issue:

      1. Turn on the multi-language filter (and change the dropdown to “Content and headings”)
      2. Create a new course
      3. Enable activity tracking within the course (in the course settings)
      4. Create some new activities in the course (using the <span class=”multilang” lang=”cy”>WELSH</span><span class=”multilang” lang=”en”>ENGLISH</span> format)
      5. View the activity completion report - Course Administration>Report>Activity Completion

      Version Moodle 2.7.1+

      Please let me know if you need any further information.

      Thanks
      Gary

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    6/Jul/15