Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49065

Display 'You have lessons that need attention' when more relevant to students.

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.3
    • Fix Version/s: 2.9
    • Component/s: Lesson
    • Labels:
    • Testing Instructions:
      Hide

      Automated tests:
      1. Run the behat test for: mod/lesson/tests/behat/lesson_student_my_home.feature

      Manual testing:
      1. Create a lesson containing a few pages (any type will work) and enable the deadline field, with a close finish date.
      2. As a student View the "my home" page before starting the lesson, after the lesson has been started but not completed, and once the lesson has been completed. Verify that the correct status is displayed.
      3. Repeat step 2 with a variety of settings (specifically with "practice lesson" set both to yes and no and with "re-takes allowed" set to both yes and no).
      4. Verify in all cases that the correct status is displayed to students. (If the student has completed the lesson and re-takes are set to no, then the lesson should not appear in the course overview block)

      Show
      Automated tests: 1. Run the behat test for: mod/lesson/tests/behat/lesson_student_my_home.feature Manual testing: 1. Create a lesson containing a few pages (any type will work) and enable the deadline field, with a close finish date. 2. As a student View the "my home" page before starting the lesson, after the lesson has been started but not completed, and once the lesson has been completed. Verify that the correct status is displayed. 3. Repeat step 2 with a variety of settings (specifically with "practice lesson" set both to yes and no and with "re-takes allowed" set to both yes and no). 4. Verify in all cases that the correct status is displayed to students. (If the student has completed the lesson and re-takes are set to no, then the lesson should not appear in the course overview block)
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull Master Branch:
      MDL-49065_m29v6

      Description

      The information provided to students by the lesson_print_overview() function is inaccurate to students in several circumstances:

      1. If the student has started a lesson, regardless of whether they have completed it it shows it as attempted:
      https://github.com/sbourget/moodle/blob/master/mod/lesson/lib.php#L291
      2. If a student has completed a lesson that allows multiple attempts the lesson is simply marked "Attempted", with no indication that they can re-attempt the lesson
      3. If a student has completed a lesson that only allows one attempt, it is displayed as needing attention
      4. Practice lessons are always displayed as not attempted unless they have been started and not completed.

      This issue proposes making the information displayed to students more useful.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              sbourget Stephen Bourget
              Reporter:
              sbourget Stephen Bourget
              Peer reviewer:
              David Monllaó
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Simey Lameze
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15