Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49098

Feedback module completion message concatenates language strings

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.5, 2.8.3, 2.9
    • Fix Version/s: 3.0
    • Component/s: Feedback
    • Labels:
    • Testing Instructions:
      Hide
      1. Set up email on your moodle instance
        1. apt-get install mailcatcher

        2. mailcatcher

        3. Add to your config:

          $CFG->smtphosts = '127.0.0.1:1025';

      2. Enable the feedback module (Site administration ► Plugins ► Activity modules ► Manage activities)
      3. Create a feedback activity
      4. Set "Enable notification of submissions" to "Yes"
      5. Enrol a user
      6. Log in as that user
      7. Complete feedback activity
      8. Ensure the email you receive matches this format: "User X completed Feedback Activity Y"
      Show
      Set up email on your moodle instance apt-get install mailcatcher mailcatcher Add to your config: $CFG ->smtphosts = '127.0.0.1:1025' ; Enable the feedback module (Site administration ► Plugins ► Activity modules ► Manage activities) Create a feedback activity Set "Enable notification of submissions" to "Yes" Enrol a user Log in as that user Complete feedback activity Ensure the email you receive matches this format: "User X completed Feedback Activity Y"
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-49098-master

      Description

      mod/feedback/lib.php:line 2955 and line 3025 concatenate a string a username and an activity name. Instead the 'feedback' language string definition in should be changed to something like

      $string['completed'] = 'completed: {$a->username} -> {$a->feedbackname}';

      and the other parts of the string passed in. This will ensure other language packs can have better grammar.

      Note I just wrote an exact equivalent. It would be better to rewrite this to be more straightforward such as '{$a->username} completed {$a->feedbackname}'

        Attachments

          Activity

            People

            Assignee:
            moodle.com moodle.com
            Reporter:
            johno John Okely
            Peer reviewer:
            John Okely
            Integrator:
            Dan Poltawski
            Tester:
            Ankit Agarwal
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              16/Nov/15