Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49103

Badge baking uses tEXt instead of iTXt

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Requirements

      1. One account on badgr.io

      Setup

      1. As admin verify that badges are enabled in "Site administration / Advanced features".
      2. Configure Badgr as you default backpack: https://docs.moodle.org/en/Badges_settings#Enabling_Badgr_as_the_active_external_backpack
      3. Go to "Site administration / Badges / Manage Badges / Add a new badge" and create a badge at site level "Badge1".
      4. Add a criteria to the badge so it can be manually issued by role.
      5. Enable the badge.
      6. Issue the badge to the admin user.
      7. Access to "Site administration / Badges / Backpack settings" and make sure the site backpack is set to "https://badgr.io".

      Testing instructions

      1. View admin's profile page.
      2. In the "Badges" section, click over the badge "Badge1".
      3. Download the badge.
      4. Open the downloaded png badge file in a text editor (such as gedit, notepad or sublime).
      5. Check the file contains "iTXtopenbadges".
      6. Check the file contains "@context".

       

      Show
      Requirements One account on badgr.io Setup As admin verify that badges are enabled in "Site administration / Advanced features". Configure Badgr as you default backpack:  https://docs.moodle.org/en/Badges_settings#Enabling_Badgr_as_the_active_external_backpack Go to "Site administration / Badges / Manage Badges / Add a new badge" and create a badge at site level "Badge1". Add a criteria to the badge so it can be manually issued by role. Enable the badge. Issue the badge to the admin user. Access to "Site administration / Badges / Backpack settings" and make sure the site backpack is set to "https://badgr.io". Testing instructions View admin's profile page. In the "Badges" section, click over the badge "Badge1". Download the badge. Open the downloaded png badge file in a text editor (such as gedit, notepad or sublime). Check the file contains "iTXtopenbadges". Check the file contains "@context".  
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull from Repository:
    • Pull 3.7 Branch:
    • Pull 3.8 Branch:
    • Pull Master Branch:
      MDL-49103-master
    • Sprint:
      Moodle 3.9 - Moppies Kanban

      Description

      The latest Open Badges spec requires use of iTXt instead of tEXt for baking of badges. Moodle uses tEXt.

      See:
      https://github.com/moodle/moodle/blob/da0ef2e4cf9c02cfa0444814b4e6e9b2cb000cd6/lib/badgeslib.php#L1015

      https://github.com/moodle/moodle/commit/853e506a1b6ba9ed3af1faec88cfb55c4c7a3f61#diff-714e633d117fead32136ce884ae58b47L123

      https://github.com/openbadges/openbadges-specification/blob/master/Badge-Baking/latest.md#baking

      Simply replacing "tEXt" with "iTXt" in the function call type parameter does not seem to be sufficient.

      In lieu of code, any direction or advice on fixing this appreciated. I'm actually using this library outside of Moodle to generate badges and will happily contribute a fix back.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              sarjona Sara Arjona (@sarjona)
              Reporter:
              garemoko Andrew Downes
              Peer reviewer:
              Carlos Escobedo
              Integrator:
              Andrew Nicols
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Yuliya Bozhko, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              2 Vote for this issue
              Watchers:
              12 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Mar/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 45 minutes
                  5h 45m