Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49143

LTI request is missing resource_link_id which is required according to LTI spec

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      1. As admin navigate to Site administration > Plugins > Activity modules > LTI > Manage external tool type
      2. Add an external tool configuration with the following:

      • Tool name: My LTI Tool
      • Tool base URL: mithrandir.per.in.moodle.com/tool.php
      • Make sure "Show tool type when creating tool instances" is checked.

      3. Create a new course
      4. Navigate to your new course and enable editing.
      5. Click "Add an Activity or Resource"
      6. Select "External Tool" and click "Add"
      7. Fill out the form with the following:

      • Activity name: My Activity
      • External tool type: My LTI Tool

      8. Click "Save and return to course"
      9. Click on the new "My Activity" link.
      10. Verify that resource_link_id appears in the output.
      11. Optionally create another activity to verify that the ID changes.

      Show
      1. As admin navigate to Site administration > Plugins > Activity modules > LTI > Manage external tool type 2. Add an external tool configuration with the following: Tool name: My LTI Tool Tool base URL: mithrandir.per.in.moodle.com/tool.php Make sure "Show tool type when creating tool instances" is checked. 3. Create a new course 4. Navigate to your new course and enable editing. 5. Click "Add an Activity or Resource" 6. Select "External Tool" and click "Add" 7. Fill out the form with the following: Activity name: My Activity External tool type: My LTI Tool 8. Click "Save and return to course" 9. Click on the new "My Activity" link. 10. Verify that resource_link_id appears in the output. 11. Optionally create another activity to verify that the ID changes.
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-49143-master
    • Pull Master Diff URL:
    • Sprint:
      Team Both Sprint 1

      Description

      in 2.8(.2), when using the lti_build_request(..) method (in mod/lti/locallib.php) - the request params returned by that function does not include resource_link_id.

      in comparison to the new method - lti_build_standard_request - there this parameter is being added.

      if there was no good reason to drop it - I think it should be placed back into the lti_build_request function.

        Attachments

          Activity

            People

            Assignee:
            cameron1729 cameron1729
            Reporter:
            gonen.radai gonen radai, Kaltura
            Peer reviewer:
            John Okely
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Mark Nelson
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Nov/15