[MDL-49145] log report error for event contexts - Moodle Tracker

XML

Word

Printable

Database:

MySQL
Testing Instructions:

Hide

1. log in
2. go to site administration - reports - logs
3. click on button 'get these logs'
4. click on any link in the 'Event context' column
5. See if you get the error Not Found The requested URL /report/log/1 was not found on this server.
6. go to site administration - reports - live logs
7. click on any link in the 'Event context' column
6. The link opens a valid page

Show
1. log in 2. go to site administration - reports - logs 3. click on button 'get these logs' 4. click on any link in the 'Event context' column 5. See if you get the error Not Found The requested URL /report/log/1 was not found on this server. 6. go to site administration - reports - live logs 7. click on any link in the 'Event context' column 6. The link opens a valid page
URL:
http://qa.moodle.net/report/log/index.php?chooselog=1&showusers=0&showcourses=0&id=1&user=&date=&modid=&modaction=&edulevel=-1&logreader=logstore_standard
Affected Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Pull from Repository:
git://github.com/dmonllao/moodle.git
Pull Master Branch:
~~MDL-49145~~_master
Pull Master Diff URL:
https://github.com/dmonllao/moodle/compare/MDL-49145_master

The links generated in the events context column of the log report are all links to /report/log/1

Error visible on qa.moodle.net

Error not existing on demo.moodle.net

I suspect it is a cache issue, as when you change line 199 from the file
report/log/classes/table_log.php

if ($url = $context->get_url() && empty($this->download)) {

    $contextname = html_writer::link($url, $contextname);

into

if ($url = $context->get_url() && empty($this->download)) {

    $contextname = html_writer::link($context->get_url(), $contextname);

the error disappears.

blocks

MDL-48595 Log exports still consume all memory and fail

has been marked as being related by

MDL-48702 Improve course log export resource consumption and reliability (backport of MDL-34867)

is a regression caused by

MDL-46626 Log report export contains html

is duplicated by

MDL-49162 report_log Event context link not working after MDL-34867

Participants:: Andrew Lyons, CiBoT, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7), Marina Glancy, Mary Cooch, Renaat Debleu, Tyler Bannister

Component watchers:: Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan