Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49165

theme option 'langmenu' is not respected in bootstrapbase-based themes

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.8.3
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_28_STABLE

      Description

      I accidentally discovered it while testing MDL-37477, I noticed that language menu is displayed on admin pages in Clean theme but not displayed in Base. Digging into the code I noticed that base looks at $PAGE->layout_options['langmenu'] before displaying language menu and Bootstrapbase, Clean and More don't.

      config file for bootstrapbase defines 'options' => array('langmenu'=>true), for some layouts just as well as in base. But they are ignored when displaying the page.

      Interesting that 'nonavbar' layout option is respected in CSS only. So for example, on frontpage the navbar is still rendered but hidden by the rule:

      .layout-option-noheader #page-header, .layout-option-nonavbar #page-navbar, .layout-option-nofooter #page-footer, .layout-option-nocourseheader .course-content-header, .layout-option-nocoursefooter .course-content-footer {
          display: none;
      }
      

      I remember this obsession with CSS caused MDL-41398

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              marina Marina Glancy
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated: