Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49167

YUI combo loading broken by param cleaning in case of $CFG->yuislasharguments=1

    XMLWordPrintable

Details

    • MOODLE_27_STABLE
    • MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • MDL-49167-master
    • Hide

      Set the following settings:
      $CFG->yuicomboloading = 1;
      $CFG->yuislasharguments = 1;
      (Note, the second can only be set in config.php, not via the Admin interface)

      If required, setup the rewrite rule for yuislasharguments (See MDL-33636).

      Purge all caches (including browser cache).
      Log in and visit the home page.
      Check that action menus on the course edit screen can still be opened/closed.
      Double-check that MDL-48980 is still fixed.

      Show
      Set the following settings: $CFG->yuicomboloading = 1; $CFG->yuislasharguments = 1; (Note, the second can only be set in config.php, not via the Admin interface) If required, setup the rewrite rule for yuislasharguments (See MDL-33636 ). Purge all caches (including browser cache). Log in and visit the home page. Check that action menus on the course edit screen can still be opened/closed. Double-check that MDL-48980 is still fixed.

    Description

      The recent cleaning introduced in MDL-48980 breaks YUI combo loading in situations where this falls back to calling min_get_slash_argument().

      If the function combo_params() in theme/yui_combo.php does not find the params it needs in either $_SERVER['QUERY_STRING'] or $_SERVER['REQUEST_URI'], it falls back to calling min_get_slash_argument(). I do not know the full set of circumstances in which this fallback is used, but, due to the changes in MDL-48980, '&' characters will always be removed from the params. As a result the combo loading (which concatenates multiple files together using '&') will always fail when this fallback is used.

      Disabling YUI combo loading is a workaround for this.

      Attachments

        Activity

          People

            damyon Damyon Wiese
            davosmith Davo Smith
            Frédéric Massart Frédéric Massart
            David Monllaó David Monllaó
            Dave Cooper Dave Cooper
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
            Votes:
            2 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              9/Mar/15