Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49176

Assigment marking guide 'flattens' instructions for markers and students

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.5, 2.8.3, 3.0
    • Fix Version/s: 3.0
    • Component/s: Assignment
    • Testing Instructions:
      Hide
      1. Create a marking guide
      2. Make sure that some of the grade descriptions, marker grade descriptions and frequently used comments have newline characters in them
      3. Save and edit the marking guide again
        • Make sure the text area showing the editable text does not have any 'br' tags in it
        • Make sure the non-editing display of the guides/comments displays the newlines (inspecting the HTML should show that 'br' tags have been inserted to make this work)
      4. Select the marking guide for an assignment
      5. Grade the assignment
        • Make sure the grade descriptions and marker grade descriptions display with the newlines preserved
        • Make sure the frequently used comments display with the newlines preserved and that clicking on one of them inserts it into the relevant box (but that the 'br' tags do not appear in the comment box)
      6. Log in as a student and make sure the grade descriptions appear with the newlines preserved.
      Show
      Create a marking guide Make sure that some of the grade descriptions, marker grade descriptions and frequently used comments have newline characters in them Save and edit the marking guide again Make sure the text area showing the editable text does not have any 'br' tags in it Make sure the non-editing display of the guides/comments displays the newlines (inspecting the HTML should show that 'br' tags have been inserted to make this work) Select the marking guide for an assignment Grade the assignment Make sure the grade descriptions and marker grade descriptions display with the newlines preserved Make sure the frequently used comments display with the newlines preserved and that clicking on one of them inserts it into the relevant box (but that the 'br' tags do not appear in the comment box) Log in as a student and make sure the grade descriptions appear with the newlines preserved.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-49176_marking_guide
    • Pull Master Diff URL:

      Description

      In the marking guide, no form of formatting is possible in the instructions for markers/students edit boxes. Intuitively you would probably expect new lines entered in the edit box to be respected but they are not. The whole thing is flattened. If there is any complexity to the instructions this can make them very hard to read.

      I expect that all the output is missing is some <pre> tags.

        Attachments

          Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-49893 Marking Guide: Textarea has no text editor and displays texts with line breaks in one line

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-50898 Assignment marking guide description for markers is not well styled

          • Minor - Minor loss of function where workaround is possible
          • Open
          will be (partly) resolved by

          Improvement - An enhancement to an existing Moodle feature. MDL-47245 Create very cut down editor for places that currently use a textbox

          • Minor - Minor loss of function where workaround is possible
          • Open

            Activity

              People

              Assignee:
              davosmith Davo Smith
              Reporter:
              howardsmiller Howard Miller
              Peer reviewer:
              Ryan Wyllie
              Integrator:
              Andrew Nicols
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              3 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                16/Nov/15