Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49187

Lookup for tool only uses URL matching

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Configure an external tool on the Manage external tool types page and ensure the "Show tool type when creating tool instances" box is checked.
      2. Go to a course as a teacher and add an instance of this tool (leave launch container option set to default).
      3. Launch the tool and note where it is opened.
      4. Go back to the Manage external tool types page and change the setting for the "Default launch container" option.
      5. Return to the course and re-launch the tool
      6. It should open honoring the new launch container option you just set
      Show
      Configure an external tool on the Manage external tool types page and ensure the "Show tool type when creating tool instances" box is checked. Go to a course as a teacher and add an instance of this tool (leave launch container option set to default). Launch the tool and note where it is opened. Go back to the Manage external tool types page and change the setting for the "Default launch container" option. Return to the course and re-launch the tool It should open honoring the new launch container option you just set
    • Workaround:
      Hide

      None.

      Show
      None.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull Master Branch:

      Description

      When the configuration parameters for a tool are extracted in view.php, it searches for the tool using the URL field even if the ID of the tool is known. Since an LTI instance should only have one or the other (a typeid or a URL) the current code means that it does not locate the configuration parameters when no URL is present and any change to the default launch container is not identified.

        Attachments

          Activity

            People

            Assignee:
            svickers Stephen Vickers
            Reporter:
            svickers Stephen Vickers
            Peer reviewer:
            John Okely John Okely
            Integrator:
            Dan Poltawski Dan Poltawski
            Tester:
            Jetha Chan Jetha Chan
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/May/15