Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49244

core_course_get_categories doesn't clean the criteria parameters

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.5, 2.8.3, 2.9.6, 3.0.4, 3.1, 3.2
    • Fix Version/s: 3.0.5, 3.1.1
    • Component/s: Web Services
    • Labels:
    • Testing Instructions:
      Hide

      I added a new test covering this case, so I think that running unit tests (course/tests/externallib_tests.php should be enough)
      You can also try to apply only the changes of the unit test and check that then it fails when they are executed, and with the whole patch it works.

      Show
      I added a new test covering this case, so I think that running unit tests (course/tests/externallib_tests.php should be enough) You can also try to apply only the changes of the unit test and check that then it fails when they are executed, and with the whole patch it works.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE, MOODLE_32_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE, MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-49244-master

      Description

      It really uses clean_param for checking each parameter but at the end it assigns the uncleaned parameter again to a fresh conditions array.

      After talking with Eloy he decided that inside each case verifications for each type of param must be done, that means that the if (isset($value) should be removed

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jleyva Juan Leyva
              Reporter:
              jleyva Juan Leyva
              Peer reviewer:
              Jun Pataleta
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jul/16