Adjusting weights when extra credit item is present causes unexpected behavior

Test 0 (before upgrade) Copy behat tests from this branch *_20150619.feature and put them into the non-upgraded instance Remove the step "gradebook calculations for the course ... are frozen at version ..." (it does not exist yet) Run those tests and make sure they pass Test 1 (upgrade) Create two courses with natural aggregation method, normal and extra credit items In the second course adjust some weights Grade some students, leave the grader report and user reports open to compare with after upgrade. Create backups of both courses (lets call them "backup #1" and "backup #2", you'll use them in test 2) Upgrade Compare the grader report and user reports with the ones before upgrade, make sure they are identical The second course (one with adjusted weights) must show the warning about fixed gradebook calculations, make sure the warning text is understandable Without accepting remove weights overriddes and make backup (backup #3) Test 2 (restore, use the already upgraded Moodle) Before testing hack your version.php and set the build number in $release to something in the future (imagine we already released the next weeklies) Restore backups that you made in test 1 as NEW COURSES Make sure course from backup #1 does not display a warning in the gradebook and backups #2 and #3 do Accept changes in the course that was restored from backup #2 and make a backup of this course Restore this as a new course and make sure the warning is not displayed. What do we test here: if backup was made after the fix, the course will not be marked as freezed when restored Test 3 (on the upgraded Moodle) watch the video from the first comment and try to do the same - the grades should not jump like crazy. Review the new behat test and make sure it makes sense