Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49257

Adjusting weights when extra credit item is present causes unexpected behavior

XMLWordPrintable

    • MOODLE_28_STABLE
    • MOODLE_28_STABLE, MOODLE_29_STABLE
    • wip-MDL-49257-master
    • Hide

      Test 0 (before upgrade)

      1. Copy behat tests from this branch *_20150619.feature and put them into the non-upgraded instance
      2. Remove the step "gradebook calculations for the course ... are frozen at version ..." (it does not exist yet)
      3. Run those tests and make sure they pass

      Test 1 (upgrade)

      1. Create two courses with natural aggregation method, normal and extra credit items
      2. In the second course adjust some weights
      3. Grade some students, leave the grader report and user reports open to compare with after upgrade.
      4. Create backups of both courses (lets call them "backup #1" and "backup #2", you'll use them in test 2)
      5. Upgrade
      6. Compare the grader report and user reports with the ones before upgrade, make sure they are identical
      7. The second course (one with adjusted weights) must show the warning about fixed gradebook calculations, make sure the warning text is understandable
      8. Without accepting remove weights overriddes and make backup (backup #3)

      Test 2 (restore, use the already upgraded Moodle)
      Before testing hack your version.php and set the build number in $release to something in the future (imagine we already released the next weeklies)

      1. Restore backups that you made in test 1 as NEW COURSES
      2. Make sure course from backup #1 does not display a warning in the gradebook and backups #2 and #3 do
      3. Accept changes in the course that was restored from backup #2 and make a backup of this course
      4. Restore this as a new course and make sure the warning is not displayed. What do we test here: if backup was made after the fix, the course will not be marked as freezed when restored

      Test 3 (on the upgraded Moodle)
      watch the video from the first comment and try to do the same - the grades should not jump like crazy. Review the new behat test and make sure it makes sense

      Show
      Test 0 (before upgrade) Copy behat tests from this branch *_20150619.feature and put them into the non-upgraded instance Remove the step "gradebook calculations for the course ... are frozen at version ..." (it does not exist yet) Run those tests and make sure they pass Test 1 (upgrade) Create two courses with natural aggregation method, normal and extra credit items In the second course adjust some weights Grade some students, leave the grader report and user reports open to compare with after upgrade. Create backups of both courses (lets call them "backup #1" and "backup #2", you'll use them in test 2) Upgrade Compare the grader report and user reports with the ones before upgrade, make sure they are identical The second course (one with adjusted weights) must show the warning about fixed gradebook calculations, make sure the warning text is understandable Without accepting remove weights overriddes and make backup (backup #3) Test 2 (restore, use the already upgraded Moodle) Before testing hack your version.php and set the build number in $release to something in the future (imagine we already released the next weeklies) Restore backups that you made in test 1 as NEW COURSES Make sure course from backup #1 does not display a warning in the gradebook and backups #2 and #3 do Accept changes in the course that was restored from backup #2 and make a backup of this course Restore this as a new course and make sure the warning is not displayed. What do we test here: if backup was made after the fix, the course will not be marked as freezed when restored Test 3 (on the upgraded Moodle) watch the video from the first comment and try to do the same - the grades should not jump like crazy. Review the new behat test and make sure it makes sense

      Weight for an extra credit item is always a calculated value based on container elements

        1. EricMerrillGradeEC.png
          522 kB
          Eric Merrill
        2. grades1-1.png
          24 kB
          Marina Glancy
        3. grades1-2.png
          24 kB
          Marina Glancy
        4. grades1-3.png
          26 kB
          Marina Glancy
        5. grades2-1.png
          24 kB
          Marina Glancy
        6. grades2-1fixed.png
          24 kB
          Marina Glancy
        7. grades2-2.png
          24 kB
          Marina Glancy
        8. grades2-2fixed.png
          24 kB
          Marina Glancy
        9. grades2-3.png
          26 kB
          Marina Glancy
        10. grades2-3fixed.png
          26 kB
          Marina Glancy
        11. grades3-1.png
          23 kB
          Marina Glancy
        12. grades3-1fixed.png
          24 kB
          Marina Glancy
        13. grades3-2.png
          24 kB
          Marina Glancy
        14. grades3-2fixed.png
          24 kB
          Marina Glancy
        15. grades3-3.png
          26 kB
          Marina Glancy
        16. grades3-3fixed.png
          26 kB
          Marina Glancy
        17. grades5-1.png
          31 kB
          Marina Glancy
        18. grades5-1fixed.png
          24 kB
          Marina Glancy
        19. grades5-2.png
          25 kB
          Marina Glancy
        20. grades5-2fixed.png
          27 kB
          Marina Glancy
        21. grades5-3.png
          27 kB
          Marina Glancy
        22. grades5-3fixed.png
          29 kB
          Marina Glancy
        23. Screen Shot 2015-02-20 at 11.09.21 AM.jpg
          257 kB
          Mark McKay
        24. Screen Shot 2015-02-20 at 11.10.33 AM.jpg
          259 kB
          Mark McKay
        25. setup1.png
          24 kB
          Marina Glancy
        26. setup2.png
          25 kB
          Marina Glancy
        27. setup2fixed.png
          25 kB
          Marina Glancy
        28. setup3.png
          25 kB
          Marina Glancy
        29. setup3fixed.png
          25 kB
          Marina Glancy
        30. setup5.png
          26 kB
          Marina Glancy

            marina Marina Glancy
            bobpuffer Bob Puffer
            Damyon Wiese Damyon Wiese
            Dan Poltawski Dan Poltawski
            Rajesh Taneja Rajesh Taneja
            Votes:
            20 Vote for this issue
            Watchers:
            21 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.