Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49281

Gradebook calculations cannot be edited after upgrade

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-49281-master
    • Testing Instructions:
      Hide
      1. Setup a 2.7 site
      2. Make sure that grade_report_showcalculations is turned off (default)
      3. Go to a course and setup a grade category (Course administration -> Grades -> Setup -> Categories and items ) or add a grade item
      4. Add calculation to this category or item
      5. Update the site with this patch and make sure that:
        1. you can still edit this calculation but you cannot create a new one
        2. if you delete this calculation, you cannot add new one to the same category/item
        3. grade_report_showcalculations is listed in new settings during upgrade
        4. If you uncheck grade_report_showcalculations during upgrade, you are still able to edit previously created calculation, but you are not able to add calculation to any new created grade item or grade item which did not have any calculations before upgrade
      Show
      Setup a 2.7 site Make sure that grade_report_showcalculations is turned off (default) Go to a course and setup a grade category (Course administration -> Grades -> Setup -> Categories and items ) or add a grade item Add calculation to this category or item Update the site with this patch and make sure that: you can still edit this calculation but you cannot create a new one if you delete this calculation, you cannot add new one to the same category/item grade_report_showcalculations is listed in new settings during upgrade If you uncheck grade_report_showcalculations during upgrade, you are still able to edit previously created calculation, but you are not able to add calculation to any new created grade item or grade item which did not have any calculations before upgrade
    • Sprint:
      Team Beards Sprint 5, Team Beards Sprint 6

      Description

      If a site has calculations in the gradebook and grade_report_showcalculations is off (but teachers are still able to see the icon and add calculations), and is upgraded to 2.8, the teachers will not be able to edit the calculations (grade_report_showcalculations behaviour is fixed and teachers won't see an icon).

      The solution to this would be to allow calculation edit if it already exists even if a global or user preferences are off. Other proposed solutions doesn't seem to work (see comments).

      I think 2 things should happen.

      1. We should add an upgrade step to enable the setting if there are calculations in any gradebook on the site.
      2. Even if the setting is off - if a grade item already has a calculation we should still let you edit it.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mastnym Martin Mastny
              Reporter:
              damyon Damyon Wiese
              Peer reviewer:
              Tim Hunt Tim Hunt
              Integrator:
              David Monllaó David Monllaó
              Tester:
              Mark Nelson Mark Nelson
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              3 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15