Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49311

Course user list default sort "by lastaccess" funciton is not working

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-49311-master
    • Testing Instructions:
      Hide
      1. In a course with few enrolled users, do some logins with different users(students, teachers).
      2. Log in as admin.
      3. Visit that Course and go to participants.
      4. Make sure the default sorting is working displaying the latest logins first.
      5. Try other sorting and make sure it's working as expected.
      Show
      In a course with few enrolled users, do some logins with different users(students, teachers). Log in as admin. Visit that Course and go to participants. Make sure the default sorting is working displaying the latest logins first. Try other sorting and make sure it's working as expected.
    • Sprint:
      Team Beards Sprint 5

      Description

      Go to your course and check "Home > Current course > YOUR COURSE > Participants". I think the commit broke the ordering function.

      https://github.com/moodle/moodle/commit/f0ba13d41f1747d6a34f54655f17dfefd2774c49#diff-289887437aadb09de4cebddcc7bd5af4L357

      I restore sort table col key "lastuseraccess" to "lastaccess" it seems work fine.

          if (!isset($hiddenfields['lastaccess'])) {
              $table->sortable(true, 'lastaccess', SORT_DESC);
          } else {
              $table->sortable(true, 'firstname', SORT_ASC);
          }
      

      Pull Diff URL
      Master https://github.com/moodle/moodle/compare/master...papillon326:master
      2.8 https://github.com/moodle/moodle/compare/MOODLE_28_STABLE...papillon326:patch-1
      2.7 https://github.com/moodle/moodle/compare/MOODLE_27_STABLE...papillon326:patch-3

        Attachments

        1. after.png
          after.png
          33 kB
        2. before.png
          before.png
          34 kB

          Issue Links

            Activity

              People

              Assignee:
              papillon326 Mitsuru Udagawa
              Reporter:
              papillon326 Mitsuru Udagawa
              Peer reviewer:
              Simey Lameze Simey Lameze
              Integrator:
              Andrew Lyons Andrew Lyons
              Tester:
              Rajesh Taneja Rajesh Taneja
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15