[MDL-49332] Gradebook calculation may timeout - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 2.8 regressions, 2.8.3
Fix Version/s: 2.7.8, 2.8.6
Component/s: Gradebook
Labels:
- ci
- triaged

Affected Branches:
MOODLE_28_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Pull from Repository:
git://github.com/merrill-oakland/moodle.git
Pull Main Branch:
~~MDL-49332~~-master
Pull Main Diff URL:
https://github.com/merrill-oakland/moodle/compare/b90f98d...MDL-49332-master
Testing Instructions:
Hide

Apply the patch file "0001-Testing-~~MDL-49332~~.patch"

Generate a XL sized test course (it will not take hours because I commented out the files/assignments/forum posts etc).
#Go to the grader report page. Once it loads, go into the database and find the course grade_item for the course, set needsupdate to 1.

Reload the grader report and confirm it finishes
#Revert this branch, go into the database and find the course grade_item for the course, set needsupdate to 1.
#Reload the grader report and confirm it fails to load

Note: that if you have your default php max_exectution_time raised, it may not fail even with this ticket not applied
Show
Apply the patch file "0001-Testing- MDL-49332 .patch" Generate a XL sized test course (it will not take hours because I commented out the files/assignments/forum posts etc). #Go to the grader report page. Once it loads, go into the database and find the course grade_item for the course, set needsupdate to 1. Reload the grader report and confirm it finishes #Revert this branch, go into the database and find the course grade_item for the course, set needsupdate to 1. #Reload the grader report and confirm it fails to load Note: that if you have your default php max_exectution_time raised, it may not fail even with this ticket not applied

Description

The new gradebook recalculation is much more intensive, and sometimes may cause a 30sec timeout, making it so you can never finish.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

0001-Testing-MDL-49332.patch
6 kB
28/Feb/15 6:48 AM

Issue Links

has a non-specific relationship to

MDL-47911 Incredibly inefficient gradebook operations on moodle.org quiz in 2.8

Closed

has been marked as being related by

MDL-55987 Gradebook calculation may need a lot of memory

Closed

Activity

People

Assignee:: Eric Merrill

Reporter:: Eric Merrill

Peer reviewer:: Zachary Durber

Integrator:: David Monllaó

Tester:: Jetha Chan

Participants:: CiBoT, David Monllaó, Eloy Lafuente (stronk7), Eric Merrill, Jetha Chan, Zachary Durber

Votes:: 2 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 28/Feb/15 5:42 AM

Updated:: 17/Sep/16 1:35 AM

Resolved:: 13/Mar/15 9:17 PM

Fix Release Date:: 11/May/15