Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49360

Use get_local_referer() rather direct HTTP_REFERER directly

    XMLWordPrintable

Details

    • MOODLE_28_STABLE, MOODLE_29_STABLE
    • MOODLE_28_STABLE, MOODLE_29_STABLE
    • MDL-49360-master
    • Hide
      Exploratory testing
      1. Repeat the instructions of the MDL-49179.
      2. Open the patch and check for places where $_SERVER['HTTP_REFERER'] and $_SERVER["HTTP_REFERER"] was replaced by get_local_referer().
        • Note: $_SERVER['HTTP_REFERER'] still present on lib/deprecatelib.php and lib/weblib.php.
      3. Make sure it still works as expected.
      Show
      Exploratory testing Repeat the instructions of the MDL-49179. Open the patch and check for places where $_SERVER ['HTTP_REFERER'] and $_SERVER ["HTTP_REFERER"] was replaced by get_local_referer() . Note: $_SERVER ['HTTP_REFERER'] still present on lib/deprecatelib.php and lib/weblib.php . Make sure it still works as expected.
    • Team ';drop tables Sprint 4, Team '; drop tables Sprint 9

    Description

      Since MDL-49179 it appears clear that we should be using the API to get the HTTP referer rather than directly reading and using the value from $_SERVER['HTTP_REFERER'].

      Attachments

        Issue Links

          is blocked by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-49383 Deprecate get_referer() in favour of a safer get_referer()

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              lameze Simey Lameze
              fred Frédéric Massart
              Frédéric Massart Frédéric Massart
              Dan Poltawski Dan Poltawski
              Jetha Chan Jetha Chan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Sep/15