Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49360

Use get_local_referer() rather direct HTTP_REFERER directly

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Exploratory testing
      1. Repeat the instructions of the MDL-49179.
      2. Open the patch and check for places where $_SERVER['HTTP_REFERER'] and $_SERVER["HTTP_REFERER"] was replaced by get_local_referer().
        • Note: $_SERVER['HTTP_REFERER'] still present on lib/deprecatelib.php and lib/weblib.php.
      3. Make sure it still works as expected.
      Show
      Exploratory testing Repeat the instructions of the MDL-49179. Open the patch and check for places where $_SERVER ['HTTP_REFERER'] and $_SERVER ["HTTP_REFERER"] was replaced by get_local_referer() . Note: $_SERVER ['HTTP_REFERER'] still present on lib/deprecatelib.php and lib/weblib.php . Make sure it still works as expected.
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-49360-master
    • Sprint:
      Team ';drop tables Sprint 4, Team '; drop tables Sprint 9

      Description

      Since MDL-49179 it appears clear that we should be using the API to get the HTTP referer rather than directly reading and using the value from $_SERVER['HTTP_REFERER'].

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              lameze Simey Lameze
              Reporter:
              fred Frédéric Massart
              Peer reviewer:
              Frédéric Massart
              Integrator:
              Dan Poltawski
              Tester:
              Jetha Chan
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/15