Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49389

Possible notice when moving blocks.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.5, 2.8.3, 2.9
    • Fix Version/s: 2.7.8, 2.8.6
    • Component/s: Blocks
    • Labels:
    • Testing Instructions:
      Hide

      You need your site set to DEVELOPER debug, and you need to be able to access the PHP error logs, since the error is reported duing an ajax request, so won't appear on-screen.

      1. Go to any course page with more than one block in a column. Turn editing on.
      2. Edit the bottom block. Set the 'Weight on this page' option to 10.
      3. Move any other block by by dragging it below the block you just edited.

      Verify that the block moves with no PHP notices being logged.

      (We were seeing

      [04-Mar-2015 10:57:51 Europe/London] PHP Notice: Undefined offset: 34 in /vle/www_root/lib/blocklib.php on line 1624
      [04-Mar-2015 10:57:51 Europe/London] PHP Warning: Invalid argument supplied for foreach() in /vle/www_root/lib/blocklib.php on line 1624
      )

      Show
      You need your site set to DEVELOPER debug, and you need to be able to access the PHP error logs, since the error is reported duing an ajax request, so won't appear on-screen. Go to any course page with more than one block in a column. Turn editing on. Edit the bottom block. Set the 'Weight on this page' option to 10. Move any other block by by dragging it below the block you just edited. Verify that the block moves with no PHP notices being logged. (We were seeing [04-Mar-2015 10:57:51 Europe/London] PHP Notice: Undefined offset: 34 in /vle/www_root/lib/blocklib.php on line 1624 [04-Mar-2015 10:57:51 Europe/London] PHP Warning: Invalid argument supplied for foreach() in /vle/www_root/lib/blocklib.php on line 1624 )
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      This is just like MDL-30655, but for bottom, not top, and now we have Ajax, it is harder to test.

        Attachments

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-30655 Moving a block to top can cause warning

          • Trivial - Cosmetic problem like misspelt words or misaligned text
          • Closed

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              timhunt Tim Hunt
              Peer reviewer:
              David Mudrák (@mudrd8mz)
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15