Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49445

Behat steps for selecting list items or table rows should match the inner-most

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      This really needs to be tested together with MDL-49446.

      1. Pull the latest MDL-40990 code.
      2. Edit mod/quiz/tests/behat/editing_require_previous.feature, the scenario "Question dependency cannot apply to quizzes where the questions are shuffled so UI is hidden" that starts around like 120
      3. Change shufflequestions to 0, so the test should fail.
      4. Run that senario, and verify that Behat reports the failure

      (Until I had fixed this, and #MDL-49446, it would not fail.)

      Show
      This really needs to be tested together with MDL-49446 . Pull the latest MDL-40990 code. Edit mod/quiz/tests/behat/editing_require_previous.feature, the scenario "Question dependency cannot apply to quizzes where the questions are shuffled so UI is hidden" that starts around like 120 Change shufflequestions to 0, so the test should fail. Run that senario, and verify that Behat reports the failure (Until I had fixed this, and # MDL-49446 , it would not fail.)
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      Suppose you have nested lists like

      • Outer list item
        • Inner item 1
        • Inner item 2

      Then Behat steps like

      Then "Inner item 2" "list_item" ...

      will acutally match the Outer list item, since it looks for the first list item that contains "Inner item 2".

      I have a fix ni hand.

      The same applies to table_row.

        Attachments

          Issue Links

          blocks

          New Feature - A new Moodle feature which has yet to be developed. MDL-40990 Teachers can require students to complete Question 1 before they can see Question 2

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-49446 Bad code in many 'should not' rules in behat_general.php

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              timhunt Tim Hunt
              Peer reviewer:
              Rajesh Taneja
              Integrator:
              David Monllaó
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15