[MDL-49445] Behat steps for selecting list items or table rows should match the inner-most - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

This really needs to be tested together with ~~MDL-49446~~.

Pull the latest ~~MDL-40990~~ code.

Edit mod/quiz/tests/behat/editing_require_previous.feature, the scenario "Question dependency cannot apply to quizzes where the questions are shuffled so UI is hidden" that starts around like 120

Change shufflequestions to 0, so the test should fail.

Run that senario, and verify that Behat reports the failure

(Until I had fixed this, and #~~MDL-49446~~, it would not fail.)
Show
This really needs to be tested together with MDL-49446 . Pull the latest MDL-40990 code. Edit mod/quiz/tests/behat/editing_require_previous.feature, the scenario "Question dependency cannot apply to quizzes where the questions are shuffled so UI is hidden" that starts around like 120 Change shufflequestions to 0, so the test should fail. Run that senario, and verify that Behat reports the failure (Until I had fixed this, and # MDL-49446 , it would not fail.)
Affected Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Fixed Branches:
MOODLE_29_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-49445~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-49445

Suppose you have nested lists like

Then Behat steps like

Then "Inner item 2" "list_item" ...

will acutally match the Outer list item, since it looks for the first list item that contains "Inner item 2".

I have a fix ni hand.

The same applies to table_row.

blocks

MDL-40990 Teachers can require students to complete Question 1 before they can see Question 2

has a non-specific relationship to

MDL-49446 Bad code in many 'should not' rules in behat_general.php