Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49451

Add behat test covering MDL-49418 (and ideally other require_login implications)

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.6.9, 2.7.6, 2.8.4, 2.9
    • Fix Version/s: None
    • Labels:
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE

      Description

      This is a followup of MDL-49418 where a regression was fixed, related with some changes to require_login().

      Such a function is so complex, has so many related implications, chained dependencies... that we should try to provide some extra acceptance tests verifying different aspects that may become broken in the future.

      Of course, ideally, the function should not lead to all those chained dependencies (say modinfo, availability, theme, page, context...) and both MDL-49434 and MDL-41809 are basically about that.

      This is just to ensure some behaviors won't break with future modifications of such a central function.

      Ideas are welcome, indeed.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                stronk7 Eloy Lafuente (stronk7)
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta, Ryan Wyllie, Jake Dallimore, Jun Pataleta, Ryan Wyllie, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                2 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: