Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49481

Fix alignment of fradio and fcheckbox content on mforms (bootstrapbase)

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.7, 2.8.5, 2.9
    • Fix Version/s: 2.9
    • Component/s: Themes
    • Testing Instructions:
      Hide

      1) Download the example mform attached and place it in your moodle root folder.
      2) Go to the form in your browser.
      3) Visually inspect the formatting of the elements in different browsers and check that titles and form fields are vertically aligned

      Show
      1) Download the example mform attached and place it in your moodle root folder. 2) Go to the form in your browser. 3) Visually inspect the formatting of the elements in different browsers and check that titles and form fields are vertically aligned
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      When viewing an mform (like when adding a module), if the form has a checkbox or radio element (or group of them), the alignment of the radio/checkboxes and their labels is mismatched with the item title on the left.

      See attached screenshots for an example of what I mean (using workshop as an example - I've also copied the checkbox element used as an example to display a radio one underneath to highlight the differences there).

      This affects bootstrapbase and its children.

        Attachments

        1. mdl49481_test_form.php
          2 kB
        2. mdl49481.png
          mdl49481.png
          35 kB
        3. mdl-49481-fail1.png
          mdl-49481-fail1.png
          4 kB
        4. mdl-49481-fail2.png
          mdl-49481-fail2.png
          7 kB

          Activity

            People

            Assignee:
            aolley Adam Olley
            Reporter:
            aolley Adam Olley
            Peer reviewer:
            Adrian Greeve
            Integrator:
            David Monllaó
            Tester:
            Damyon Wiese
            Participants:
            Component watchers:
            Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/May/15