[MDL-49565] Allow comments in Atto saved code - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.7.7, 2.8.5
Fix Version/s: 2.7.8, 2.8.6
Component/s: HTML Editor (Atto)
Labels:
- ci

Affected Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Pull from Repository:
git://github.com/merrill-oakland/moodle.git
Pull Master Branch:
~~MDL-49565~~-master
Pull Master Diff URL:
https://github.com/merrill-oakland/moodle/compare/3ef9636...MDL-49565-master
Testing Instructions:

Hide

Add html comments in Atto source view,

Save content and then reload the editor

Verify comments were retained.

Show
Add html comments in Atto source view, Save content and then reload the editor Verify comments were retained.

Description

During various testing with ~~MDL-47003~~ and ~~MDL-47002~~, I have found that there is no reason to blanket remove HTML comments from code. In fact, the display:none workaround that is push causes problems in some browsers, including Firefox.

Attachments

Issue Links

has a non-specific relationship to

MDL-47002 Atto cleaning sometimes leaves un-closed html comments

Closed

is blocked by

MDL-47003 Atto HTML cleaning is overly agressive and nonsensical

Closed

Testing discovered

MDL-49693 Atto should clean textarea before placing it in editor

Closed

Activity

People

Assignee:: Eric Merrill

Reporter:: Eric Merrill

Peer reviewer:: Damyon Wiese

Integrator:: Dan Poltawski

Tester:: John Okely

Participants:: CiBoT, Damyon Wiese, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7), Eric Merrill, John Okely

Component watchers:: Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 18/Mar/15 8:51 PM

Updated:: 28/Mar/15 8:22 AM

Resolved:: 27/Mar/15 3:19 AM

Fix Release Date:: 11/May/15