Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49573

bulk insert in single view changes activity grades it shouldn't and marks all as overridden.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Grade screen
      1. Create a course with multiple students.
      2. Create an assignment in the course.
      3. Grade one of the students in the assignment activity.
      4. Go to the gradebook and launch single view for the assignment.
      5. Note that all scores are read-only (i.e. greyed out).
      6. Check the "perform bulk insert" checkbox. Select "empty grades from the dropdown" (should be default) and enter 12 in the "insert value" textbox for the value to insert. Press save.
      7. Press continue at the "Grades were set for x items" screen.
      8. Observe that all grades should now be 12 and marked as overridden except for the one that you graded on the assignment activity itself.
      9. Go to the gradebook and make sure these changes are reflected exactly the same as they are in the single view.
      10. Ensure that the bulk insert for all grades is still working in the single view report.

      User screen
      1. Repeat the above tests but for the user singleview screen (i.e. Grade administration / ▶ Single view -> select user).

      Behat
      1. Ensure that all Behat tests pass for the @gradereport_singleview tag.

      Show
      Grade screen 1. Create a course with multiple students. 2. Create an assignment in the course. 3. Grade one of the students in the assignment activity. 4. Go to the gradebook and launch single view for the assignment. 5. Note that all scores are read-only (i.e. greyed out). 6. Check the "perform bulk insert" checkbox. Select "empty grades from the dropdown" (should be default) and enter 12 in the "insert value" textbox for the value to insert. Press save. 7. Press continue at the "Grades were set for x items" screen. 8. Observe that all grades should now be 12 and marked as overridden except for the one that you graded on the assignment activity itself. 9. Go to the gradebook and make sure these changes are reflected exactly the same as they are in the single view. 10. Ensure that the bulk insert for all grades is still working in the single view report. User screen 1. Repeat the above tests but for the user singleview screen (i.e. Grade administration / ▶ Single view -> select user). Behat 1. Ensure that all Behat tests pass for the @gradereport_singleview tag.
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-49573-master
    • Sprint:
      Team '; drop tables Sprint 6

      Description

      The behavior of using bulk insert (in the grader singleview window) doesn't seem correct to me.

      If you have an activity, and have graded some students in the activity (lets say assignment). Performing a bulk insert on empty grades in single view, will mark every single grade score for that activity as "overridden" and set the score on empty grades. It will also mark the scores graded in the assignment activity as overridden.

      create an assignment activity (AA) in a course with students.
      grade one of the studnets in the assignment activity
      go to the gradebook
      launch singleview for that grade item AA (assignment activity)
      you should see that all scores are read only
      click the checkbox for "Perform bulk insert"
      enter 12 in the text box
      leave pulldown for empty grades
      click save.

      now you will see that ALL grade scores have been overridden,
      including the one that wasn't empty.

        Attachments

          Activity

            People

            Assignee:
            davecooper Dave Cooper
            Reporter:
            smileyatic steve miley
            Peer reviewer:
            Frédéric Massart
            Integrator:
            Dan Poltawski
            Tester:
            Adrian Greeve
            Participants:
            Component watchers:
            Jake Dallimore, Jun Pataleta
            Votes:
            26 Vote for this issue
            Watchers:
            18 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/May/15