Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49575

in singleview, if you "unoverride" a score, it can fail in clearing the finalgrade field

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Go to a course with students enrolled (3 students)
      2. Add a new assignment (grade student A, give 11 pts)
      3. In the gradebook, place the assignement in a grade category
      4. Go to the single view report, and select the assignment
        • Override the grade of student A and set it to 99
        • Override the grade of student B, set it to 88
      5. Switch view to student C
        • Override the grade of the assignment, the category and the course total to the following values (in order): 77, 66, 55
      6. Go to the grade report and confirm that the right values are displayed
      7. Back to the single view, unoverride student A
      8. Confirm that the grader report displays a grade of 11 for student A
      9. In single view, unoverride student B
      10. Confirm that the grade report displays nothing, no grades.
      11. In single view, unoverride student C category total
      12. Confirm that the grade report the correct grades.
      13. In single view, unoverride student C course total
      14. Confirm that the grade report the correct grades.
      15. In single view, unoverride student C grade
      16. Confirm that the grade report the correct grades.
      Show
      Go to a course with students enrolled (3 students) Add a new assignment (grade student A, give 11 pts) In the gradebook, place the assignement in a grade category Go to the single view report, and select the assignment Override the grade of student A and set it to 99 Override the grade of student B, set it to 88 Switch view to student C Override the grade of the assignment, the category and the course total to the following values (in order): 77, 66, 55 Go to the grade report and confirm that the right values are displayed Back to the single view, unoverride student A Confirm that the grader report displays a grade of 11 for student A In single view, unoverride student B Confirm that the grade report displays nothing, no grades. In single view, unoverride student C category total Confirm that the grade report the correct grades. In single view, unoverride student C course total Confirm that the grade report the correct grades. In single view, unoverride student C grade Confirm that the grade report the correct grades.
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-49575-master
    • Sprint:
      Team '; drop tables Sprint 6

      Description

      This is a CRITICAL bug.
      different score values are shown in singleview and grader report, and the
      finalscore field in grade_grades fails to be updated properly.

      Create an assignment activity CC
      Do no grading in the assignment activity
      Go into singleview for grade item CC
      select one student and click the override checkbox
      put in a score (lets say 99)
      click save
      if you look in singleview and grader report the value will be 99 (this is correct).

      Now
      in singleview for grade item CC , uncheck the override checkbox
      click save
      In singleview, you will see no score (this is correct).
      In the grader report you will see 99 (this is the bug).

      I have a pretty good idea on the cause of the bug.
      The rawgrade in the grade_grades table has a value of NULL. I believe
      what happens on an "unoverride" is that it will attempt to update the finalgrade
      from the rawgrade field, but if the rawgrade field is null, it either fails or doesn't do it. If there was grading done in the assignment activity, the raw grade would hold a value, and when the "unoverride" is done, it would work properly.

      A secondary issue is, why does single view show the null grade.
      I believe the answer on that, is there is some additional logic that says -
      If the grade type is an activity, and the override is clear/not set, then display the grade in the rawgrade field (rather than the final grade field).

      I'm not sure if this is what should be happening.

        Attachments

          Activity

            People

            Assignee:
            fred Frédéric Massart
            Reporter:
            smileyatic steve miley
            Peer reviewer:
            Dave Cooper
            Integrator:
            David Monllaó
            Tester:
            Mark Nelson
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            26 Vote for this issue
            Watchers:
            18 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/May/15