Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49598

Switch to getimagesizefromstring in file_storage

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.9
    • 2.9
    • Files API

    Description

      MDL-32471 introduced a function to get a file preview. As part of that, it gets the image dimensions using getimagesize(). In order to do so, it writes the image data (a string) to a file, and then calls getimagesize() against the file.

      Since it was introduced, we have bumped the requirements for Moodle, and now require PHP 5.4 which introduced a getimagesizefromstring() function. This would negate the need to store the file on disk.

      Attachments

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Zachary Durber Zachary Durber
              Dan Poltawski Dan Poltawski
              Damyon Wiese Damyon Wiese
              Matteo Scaramuccia, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/May/15