Details
-
Improvement
-
Resolution: Fixed
-
Minor
-
2.9, 3.2
-
MOODLE_29_STABLE, MOODLE_32_STABLE
-
MOODLE_32_STABLE
-
MDL-49609-master-5 -
Hide
Setup
- Download and run ngrok
./ngrok http 80 --region=au
External tool configuration
- Navigate to Site administration ► Plugins ► Activity modules ► External tool ► Manage tools.
- Enter "http://lti.tools/test/tp.php" into the Tool URL... field.
- Click Add
- On the IMS LTI Tool Provider: Tool registration emulator, click Registration.
- Check out the Enabled capabilities multi-select box.
- Confirm that it contains "ContentItemSelectionRequest" under the Message types option group.
- Select all of the options under Enabled capabilities.
- Select all of the options under Tool services.
- Click Register tool.
- On the confirmation page, click Yes to activate the tool.
- Click on the Edit link (the cog icon) for the Test tool provider entry.
- Click on Show more...
- Check out the Content-Item message.
- Confirm that it is ticked.
- Confirm that it is disabled.
- Under Tool configuration usage, select Show in activity chooser and as a preconfigured tool.
- Click Save changes
- Click again on the Edit link (the cog icon) for the Test tool provider entry.
- Click on Show more...
- Check out the Content-Item message.
- Confirm that it is still ticked.
- Confirm that it is still disabled.
Adding an external tool to a course
- Create a course
- Login as a teacher enrolled to the course
- Turn editing on.
- Click Add an activity or resource. Take note of the section it is being added to.
- Select Test tool provider then click Add.
- Enter Test tool under Activity name
- Open your browser's JavaScript console.
- Click Select content
- On the IMS LTI tool provider emulator dialogue, check the Request summary
- Confirm that it says ContentItemSelectionRequest message request is valid.
- Click Content-Item.
- Click Cancel at the bottom of the page.
- Confirm that the dialogue closes.
- Confirm that there are no error messages displayed.
- Confirm that there are no JavaScript console errors after the dialogue has closed.
- Click again on Select content
- Click Content-Item.
- Select Bespoke item
- Under "Type:", select "LtiLinkItem"
- Enter a value for Title.
- Enter a value for Text.
- Enter a URL for URL.
- Enter an icon URL for Icon.
- For LTI custom parameters, enter values like
a=1
b=2
- Select a value for Select return container.
- Click Return selection
- Confirm that the dialogue closes.
- Confirm that there are no JavaScript console errors after the dialogue has closed.
- Expand all the fields and check the form.
- Confirm that Activity name is the same as the value entered in Title.
- Confirm that Activity description is the same as the value entered in Text.
- If the URL's schema is set to https, confirm that the value should be in Secure launch URL. Otherwise, it should be in Launch/cartridge URL.
- If the Icon's schema is set to https, confirm that the value should be in Secure icon URL. Otherwise, it should be in Icon URL.
- Confirm that Custom parameters is the same as the value entered in LTI custom parameters.
- Confirm that Launch container matches the selected return container. See table below:
Select return container Launch container No preference Default frame Embed, without blocks iframe Embed window New window
- Click Save and return to course.
- Confirm that Test tool was added into the course under the correct section.
Test on other editors.
- Repeat the previous test with the user's default editor preference set to TinyMCE.
- Confirm that Activity description is the same as the value entered in Text.
- Repeat the previous test with the user's default editor preference set to plain text area.
- Confirm that Activity description is the same as the value entered in Text.
Automated tests
- Run Behat tests for @mod_lti tags.
- Confirm that there are no errors nor failures.
- Run PHP unit tests for the mod_lti_testsuite.
- Confirm that there are no errors nor failures.
Backup test
- Go to a course
- Add a tool of the type you created
- Add a bespoke item, but make sure you select ltiLink
- Add a title and content
- Back it up
- Restore it on another site
- Make sure the content you selected is still displayed (it will be among the huge dump of data, use search to find it if you can't see it.
ShowSetup Download and run ngrok ./ngrok http 80 --region=au External tool configuration Navigate to Site administration ► Plugins ► Activity modules ► External tool ► Manage tools . Enter " http://lti.tools/test/tp.php " into the Tool URL... field. Click Add On the IMS LTI Tool Provider: Tool registration emulator , click Registration . Check out the Enabled capabilities multi-select box. Confirm that it contains " ContentItemSelectionRequest " under the Message types option group. Select all of the options under Enabled capabilities . Select all of the options under Tool services . Click Register tool . On the confirmation page, click Yes to activate the tool. Click on the Edit link (the cog icon) for the Test tool provider entry. Click on Show more... Check out the Content-Item message . Confirm that it is ticked. Confirm that it is disabled. Under Tool configuration usage , select Show in activity chooser and as a preconfigured tool . Click Save changes Click again on the Edit link (the cog icon) for the Test tool provider entry. Click on Show more... Check out the Content-Item message . Confirm that it is still ticked. Confirm that it is still disabled. Adding an external tool to a course Create a course Login as a teacher enrolled to the course Turn editing on. Click Add an activity or resource . Take note of the section it is being added to. Select Test tool provider then click Add . Enter Test tool under Activity name Open your browser's JavaScript console. Click Select content On the IMS LTI tool provider emulator dialogue, check the Request summary Confirm that it says ContentItemSelectionRequest message request is valid. Click Content-Item . Click Cancel at the bottom of the page. Confirm that the dialogue closes. Confirm that there are no error messages displayed. Confirm that there are no JavaScript console errors after the dialogue has closed. Click again on Select content Click Content-Item . Select Bespoke item Under " Type: ", select " LtiLinkItem " Enter a value for Title . Enter a value for Text . Enter a URL for URL . Enter an icon URL for Icon . For LTI custom parameters , enter values like a=1 b=2 Select a value for Select return container . Click Return selection Confirm that the dialogue closes. Confirm that there are no JavaScript console errors after the dialogue has closed. Expand all the fields and check the form. Confirm that Activity name is the same as the value entered in Title . Confirm that Activity description is the same as the value entered in Text . If the URL 's schema is set to https , confirm that the value should be in Secure launch URL . Otherwise, it should be in Launch/cartridge URL . If the Icon 's schema is set to https , confirm that the value should be in Secure icon URL . Otherwise, it should be in Icon URL . Confirm that Custom parameters is the same as the value entered in LTI custom parameters . Confirm that Launch container matches the selected return container. See table below: Select return container Launch container No preference Default frame Embed, without blocks iframe Embed window New window Click Save and return to course . Confirm that Test tool was added into the course under the correct section. Test on other editors. Repeat the previous test with the user's default editor preference set to TinyMCE. Confirm that Activity description is the same as the value entered in Text . Repeat the previous test with the user's default editor preference set to plain text area. Confirm that Activity description is the same as the value entered in Text . Automated tests Run Behat tests for @mod_lti tags. Confirm that there are no errors nor failures. Run PHP unit tests for the mod_lti_testsuite. Confirm that there are no errors nor failures. Backup test Go to a course Add a tool of the type you created Add a bespoke item, but make sure you select ltiLink Add a title and content Back it up Restore it on another site Make sure the content you selected is still displayed (it will be among the huge dump of data, use search to find it if you can't see it. - Download and run ngrok
Description
Add support for the LTI Content-Item message to improve the workflow when adding links to external tools in courses.
Attachments
- configure_item.png
- 105 kB
- contentitem_help.png
- 98 kB
- contentitem.png
- 83 kB
- screenshot-1.png
- 89 kB
- screenshot-2.png
- 134 kB
Issue Links
- caused a regression
-
MDL-74797 Incorrect capability check used in content item workflow
-
- Open
-
-
MDL-56232 Cannot set custom launch URL when creating an external tool
-
- Closed
-
-
MDL-56210 Random behat failure: mod/lti/tests/behat/addtool.feature
-
- Closed
-
- duplicates
-
MDL-39134 Create an LTI Filter
-
- Closed
-
- Testing discovered
-
MDL-55756 Notifications are not read out after fetchNotifications
-
- Closed
-