Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49611

err_nocriteria string missing in completion lang files

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Enable completion at site level and set a course with course completion
      2. Force the URL to report/completion/index.php?course=YOURID
      3. You SHOULD see No completion criteria set for this course
      4. Force the URL to blocks/completionstatus/details.php?course=YOURID
      5. You SHOULD see No completion criteria set for this course

      6. Extra testing if you are keen to it:
      7. Call get_course_completion_status web service function (is part of the built-in mobile service) and set course id to your course without criteria
      8. You SHOULD receive an exception with a No completion criteria set for this course
      Show
      Enable completion at site level and set a course with course completion Force the URL to report/completion/index.php?course=YOURID You SHOULD see No completion criteria set for this course Force the URL to blocks/completionstatus/details.php?course=YOURID You SHOULD see No completion criteria set for this course Extra testing if you are keen to it: Call get_course_completion_status web service function (is part of the built-in mobile service) and set course id to your course without criteria You SHOULD receive an exception with a No completion criteria set for this course
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull Master Branch:

      Description

      In some places the code is trying to get a lang string that doesn't exist: err_nocriteria from completion.php. These are the cases I found:

      Completion status block
      Report completion

      That lang string exists in gradingform_rubric.php, but not in completion.php. It should be added.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                6/Jul/15