Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49627

Update generate_image_thumbnail to not require writing temp files

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9
    • Fix Version/s: 2.9
    • Component/s: Files API, Repositories
    • Labels:
    • Testing Instructions:
      Hide
      1. navigate to a course and turn editing on
      2. Drag-and-drop upload a large image onto the course and have it "Add image to course page" (so it uses mod_label)
        • confirm that the image was displayed
      3. Navigate to your private files
      4. Upload an image
        • Confirm that a thumbnail of that image was displayed
      Show
      navigate to a course and turn editing on Drag-and-drop upload a large image onto the course and have it "Add image to course page" (so it uses mod_label) confirm that the image was displayed Navigate to your private files Upload an image Confirm that a thumbnail of that image was displayed
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-49627-master-2
    • Pull Master Diff URL:

      Description

      All places where we call generate_image_thumbnail in core first write a string to a temp file, then call generate_image_thumbnail for it, after which they throw the string away.

      Since PHP 5.4, we can now use most GD functions from the file content instead. Let's do that please!

        Attachments

          Issue Links

          has a non-specific relationship to

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDL-40034 Epic: File API improvements to handle clustering environments

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Zachary Durber
              Integrator:
              David Monllaó
              Tester:
              Dave Cooper
              Participants:
              Component watchers:
              Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15