Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49627

Update generate_image_thumbnail to not require writing temp files

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.9
    • 2.9
    • Files API, Repositories
    • MOODLE_29_STABLE
    • MOODLE_29_STABLE
    • MDL-49627-master-2
    • Hide
      1. navigate to a course and turn editing on
      2. Drag-and-drop upload a large image onto the course and have it "Add image to course page" (so it uses mod_label)
        • confirm that the image was displayed
      3. Navigate to your private files
      4. Upload an image
        • Confirm that a thumbnail of that image was displayed
      Show
      navigate to a course and turn editing on Drag-and-drop upload a large image onto the course and have it "Add image to course page" (so it uses mod_label) confirm that the image was displayed Navigate to your private files Upload an image Confirm that a thumbnail of that image was displayed

    Description

      All places where we call generate_image_thumbnail in core first write a string to a temp file, then call generate_image_thumbnail for it, after which they throw the string away.

      Since PHP 5.4, we can now use most GD functions from the file content instead. Let's do that please!

      Attachments

        Issue Links

          has a non-specific relationship to

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDL-40034 Epic: File API improvements to handle clustering environments

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Zachary Durber Zachary Durber
              David Monllaó David Monllaó
              Dave Cooper Dave Cooper
              Matteo Scaramuccia, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/May/15