Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49628

single_select has no label associated with it

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.7, 2.8.5, 2.9
    • Fix Version/s: 3.0
    • Component/s: Badges, General
    • Labels:
    • Testing Instructions:
      Hide
      • Confirm that there is a way to add labels and other attributes when using $OUTPUT->single_select. This can be done using the additional $attributes parameter in the function call
      • Confirm that there is a label or an aria-describedby associated with the "Add badge criteria" and the "Any/All" dropdown when adding a badges criteria
      • Confirm that the "select role" dropdown when going to award a badge by role has a label associated with it.
      • Confirm that the create a new field dropdown in a database activity has a label associated with it.
      • Confirm that when adding a new user profile field, the create new profile field dropdown has a label associated with it.
      • Confirm when viewing participants within a course that the "with selected users" dropdown has a label associated with it
      Show
      Confirm that there is a way to add labels and other attributes when using $OUTPUT->single_select. This can be done using the additional $attributes parameter in the function call Confirm that there is a label or an aria-describedby associated with the "Add badge criteria" and the "Any/All" dropdown when adding a badges criteria Confirm that the "select role" dropdown when going to award a badge by role has a label associated with it. Confirm that the create a new field dropdown in a database activity has a label associated with it. Confirm that when adding a new user profile field, the create new profile field dropdown has a label associated with it. Confirm when viewing participants within a course that the "with selected users" dropdown has a label associated with it
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      m29_MDL-49628a
    • Pull Master Diff URL:

      Description

      When a call is made to display a single select (via $OUTPUT->single_select(), there appears to be no way of attaching a label (and labels are needed for screen readers). One place that it is used is on criteria tab on a edit badge table.

        Attachments

          Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-50683 Not possible to select a check box for a user profile field

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              brianb Brian Barnes
              Reporter:
              brianb Brian Barnes
              Peer reviewer:
              Adrian Greeve Adrian Greeve
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              Dave Cooper Dave Cooper
              Participants:
              Component watchers:
              Yuliya Bozhko, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                16/Nov/15