Details
-
Improvement
-
Resolution: Fixed
-
Minor
-
2.8.5
-
MOODLE_28_STABLE
-
MOODLE_29_STABLE
-
MDL-49643-master-local-nav -
Description
Discussed at https://moodle.org/local/chatlogs/index.php?conversationid=17444
It seems that MDL-22209 and MDL-30506 introduced inconsistent API for the local plugins to extend navigation. Whereas in all other places the callbacks are called in the imperative mood like <plugin>_extend_navigation() and <plugin>_extend_settings_navigation(), the local plugins have them like <plugin>_extends_navigation().
Me and Eloy believe it was a mistake, probably confusion caused by the existence of the global_navigation::module_extends_navigation() method. As such, it should be fixed.
Attachments
Issue Links
- has a non-specific relationship to
-
MDL-22209 Give local plugins the ability to add to the navigation
-
- Closed
-
-
MDL-30506 Give local plugins the ability to add to the "Course administration" navigation
-
- Closed
-
-
MDL-33720 Deprecate support for local plugin navigation callback without the local_ prefix.
-
- Closed
-
- has to be done before
-
MDL-49662 Drop support for old navigation API callbacks in local plugins
-
- Closed
-