[MDL-49651] Hidden course sending forum messages - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.7.3, 3.4.4, 3.5.3, 3.6.1
Fix Version/s: 3.1.16, 3.4.7, 3.5.4, 3.6.2
Component/s: Forum
Labels:

Affected Branches:
MOODLE_27_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
Fixed Branches:
MOODLE_31_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
Pull from Repository:
git://github.com/Chocolate-lightning/moodle.git
Pull Master Branch:
~~MDL-49651~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...Chocolate-lightning:MDL-49651-master
Testing Instructions:
Hide

Create a new course with visibility hidden

Enrol one student, and one editing teacher in the course

Create a new forum in the course

Set the subscription type (via the module's settings cog) to forced subscription

Make a forum post, making sure to tick the "Send forum post notifications with no editing-time delay " box.

Run the Forum Cron Task:

php admin/tool/task/cli/schedule_task.php --execute="\mod_forum\task\cron_task"

Confirm that the student did not receive the message

Confirm the cron output did not say that the student received the post

Confirm that the teacher did receive the message

Confirm the cron output did reported that the teacher did received the post
Show
Create a new course with visibility hidden Enrol one student, and one editing teacher in the course Create a new forum in the course Set the subscription type (via the module's settings cog) to forced subscription Make a forum post, making sure to tick the "Send forum post notifications with no editing-time delay " box. Run the Forum Cron Task: php admin/tool/task/cli/schedule_task.php --execute="\mod_forum\task\cron_task" Confirm that the student did not receive the message Confirm the cron output did not say that the student received the post Confirm that the teacher did receive the message Confirm the cron output did reported that the teacher did received the post

Description

We are currently using Moodle 2.7.1 Build 20140714.
In a hidden Moodle course, messages posted to the News Forum are being sent to all users. This causes confusion because the users/students can't then see the message in context.
I had assumed that if a course (or forum) was hidden, messages would not be sent to participants.
A previous tracker ticket (~~MDL-5697~~) was posted a few years ago regarding a hidden forum sending messages.
In our case, the entire course is hidden and lecturers who are new to Moodle, have been practising editing Moodle and therefore using the News Forum in a test capacity. They, and we, assumed messages would not be sent out.
I'm not sure if this is a bug or a strange feature but perhaps someone could let me know or perhaps know a way of fixing it.
Steps I took to re-create the problem:
1) Navigate to a hidden course in Moodle
2) Post a test message in the main News Forum
3) Check to see if users with student roles received the message
In this case, both student and teacher roles received the message I posted.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2019-01-09-17-18-12-451.png
105 kB
09/Jan/19 5:18 PM
MDL-49651-29.mdk.patch
1.0 kB
01/Jun/16 11:43 PM
MDL-49651-30.mdk.patch
1.0 kB
01/Jun/16 11:43 PM
MDL-49651-31.mdk.patch
1.0 kB
01/Jun/16 11:43 PM
MDL-49651-master.mdk.patch
1.0 kB
01/Jun/16 11:39 PM

Issue Links

is duplicated by

MDL-47771 Forum activity sends notification mails to enrolled students even if the course is invisible

Closed

MDL-60113 Students receive forum notifications from hidden courses

Closed

Activity

People

Assignee:: Mathew May

Reporter:: Catherine Mclean

Peer reviewer:: Andrew Lyons

Integrator:: Jake Dallimore

Tester:: Janelle Barcega

Participants:: Amaia Anabitarte, Andrew Lyons, Catherine Mclean, CiBoT, Eloy Lafuente (stronk7), Emilie Lenel, Jake Dallimore, Janelle Barcega, Jean-Roch Meurisse, Kimberly Woodruff, Mathew May, Peter Diedrichs

Component watchers:: Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 9 Vote for this issue

Watchers:: 16 Start watching this issue

Dates

Created:: 25/Mar/15 5:40 AM

Updated:: 04/Apr/19 2:33 AM

Resolved:: 11/Jan/19 1:44 AM

Fix Release Date:: 14/Jan/19

Time Tracking

Estimated:

Remaining:

Logged: