Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49661

Do a TODO in \core\plugininfo\base::is_installed_and_upgraded()

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      There is not actually much to test. Plugins without valid version.php will throw various errors here and there anyway. Depending on the plugin type, this fix may cause plugins without version.php to disappear from the settings tree etc. Again, no specific behaviour is actually expected as such plugins should not be present.

      Show
      There is not actually much to test. Plugins without valid version.php will throw various errors here and there anyway. Depending on the plugin type, this fix may cause plugins without version.php to disappear from the settings tree etc. Again, no specific behaviour is actually expected as such plugins should not be present.
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-49661-master-pluginfotodo

      Description

      While peer-reviewing MDL-49587 I spotted a TODO that can be resolved now. All plugins are required to have valid version.php since 2.5 - see MDL-39279. It is time to stop pretending that missing version.php is a sign or correctly installed plugin.

        Attachments

          Activity

            People

            Assignee:
            mudrd8mz David Mudrák (@mudrd8mz)
            Reporter:
            mudrd8mz David Mudrák (@mudrd8mz)
            Peer reviewer:
            Michael Grant Michael Grant
            Integrator:
            Dan Poltawski Dan Poltawski
            Tester:
            Rajesh Taneja Rajesh Taneja
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/May/15