Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49662

Drop support for old navigation API callbacks in local plugins

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.5
    • Fix Version/s: 3.1
    • Component/s: Navigation
    • Labels:
    • Testing Instructions:
      Hide
      Test 1
      1. Unzip the attached 'demo.zip' file in Moodle local directory.
      2. Go through the installation process.
      3. Ensure there are no debugging messages.
      4. Ensure that the text 'Demo!' does not exist in the 'Navigation' block.
      5. Ensure that the text 'Awesome!' does not exist in the 'Administration' block.
      Test 2
      1. Edit the file local/demo/lib.php and change 'extends' in the function names to 'extend'.
      2. purge caches
      3. Refresh your browser.
      4. Ensure that the text 'Demo!' does exist in the 'Navigation' block.
      5. Ensure that the text 'Awesome!' does exist in the 'Administration' block.
      Show
      Test 1 Unzip the attached 'demo.zip' file in Moodle local directory. Go through the installation process. Ensure there are no debugging messages. Ensure that the text 'Demo!' does not exist in the 'Navigation' block. Ensure that the text 'Awesome!' does not exist in the 'Administration' block. Test 2 Edit the file local/demo/lib.php and change 'extends' in the function names to 'extend'. purge caches Refresh your browser. Ensure that the text 'Demo!' does exist in the 'Navigation' block. Ensure that the text 'Awesome!' does exist in the 'Administration' block.
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-49662_master
    • Sprint:
      3.1 Stable Sprint 2

      Description

      Given that MDL-49643 is integrated into Moodle 2.9, we should drop support for the old callbacks (with 'extends' in the name) for local plugins. The code is to be simplified to something like

      foreach (get_plugin_list_with_function('local', 'extend_navigation') as $function) {
          $function($this);
      }
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              markn Mark Nelson
              Reporter:
              mudrd8mz David Mudrák (@mudrd8mz)
              Peer reviewer:
              David Mudrák (@mudrd8mz)
              Integrator:
              Dan Poltawski
              Tester:
              Dan Poltawski
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                23/May/16