Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49693

Atto should clean textarea before placing it in editor

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.7.8, 2.8.6
    • 2.7.7, 2.8.5
    • Text editor Atto
    • MOODLE_27_STABLE, MOODLE_28_STABLE
    • MOODLE_27_STABLE, MOODLE_28_STABLE
    • MDL-49693-master
    • Hide

      This is easiest to observer with this:

      1. Enter HTML mode in atto
      2. Enter:

        <!--
        this is a unclosed comment
        

      3. Switch back to WYSISYG
      4. Switch back to HTML Mode
      5. We expect to see that the unmatched open comment tag is gone, but the text is there.
        • The unfixed version of this would cause a end html comment tag to be entered at the end of the editor content. This was because the browser saw it and decided to correct it how it saw fit
      Show
      This is easiest to observer with this: Enter HTML mode in atto Enter: <!-- this is a unclosed comment Switch back to WYSISYG Switch back to HTML Mode We expect to see that the unmatched open comment tag is gone, but the text is there. The unfixed version of this would cause a end html comment tag to be entered at the end of the editor content. This was because the browser saw it and decided to correct it how it saw fit

      When you enter HTML source mode, then switch to editor mode, Atto moves the code then cleans it. We should do it the other way around so the cleaning code can do its job before the DOM gets the code.

            emerrill Eric Merrill
            emerrill Eric Merrill
            Andrew Lyons Andrew Lyons
            Dave Cooper Dave Cooper
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.