Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49693

Atto should clean textarea before placing it in editor

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.7, 2.8.5
    • Fix Version/s: 2.7.8, 2.8.6
    • Component/s: HTML Editor (Atto)
    • Labels:
    • Testing Instructions:
      Hide

      This is easiest to observer with this:

      1. Enter HTML mode in atto
      2. Enter:

        <!--
        this is a unclosed comment
        

      3. Switch back to WYSISYG
      4. Switch back to HTML Mode
      5. We expect to see that the unmatched open comment tag is gone, but the text is there.
        • The unfixed version of this would cause a end html comment tag to be entered at the end of the editor content. This was because the browser saw it and decided to correct it how it saw fit
      Show
      This is easiest to observer with this: Enter HTML mode in atto Enter: <!-- this is a unclosed comment Switch back to WYSISYG Switch back to HTML Mode We expect to see that the unmatched open comment tag is gone, but the text is there. The unfixed version of this would cause a end html comment tag to be entered at the end of the editor content. This was because the browser saw it and decided to correct it how it saw fit
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-49693-master

      Description

      When you enter HTML source mode, then switch to editor mode, Atto moves the code then cleans it. We should do it the other way around so the cleaning code can do its job before the DOM gets the code.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/May/15