Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49693

Atto should clean textarea before placing it in editor

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.7.7, 2.8.5
    • 2.7.8, 2.8.6
    • HTML Editor (Atto)
    • MOODLE_27_STABLE, MOODLE_28_STABLE
    • MOODLE_27_STABLE, MOODLE_28_STABLE
    • MDL-49693-master
    • Hide

      This is easiest to observer with this:

      1. Enter HTML mode in atto
      2. Enter: 

        <!--
        		 
        this is a unclosed comment

      3. Switch back to WYSISYG
      4. Switch back to HTML Mode
      5. We expect to see that the unmatched open comment tag is gone, but the text is there.
        • The unfixed version of this would cause a end html comment tag to be entered at the end of the editor content. This was because the browser saw it and decided to correct it how it saw fit
      Show
      This is easiest to observer with this: Enter HTML mode in atto Enter: <!-- this is a unclosed comment Switch back to WYSISYG Switch back to HTML Mode We expect to see that the unmatched open comment tag is gone, but the text is there. The unfixed version of this would cause a end html comment tag to be entered at the end of the editor content. This was because the browser saw it and decided to correct it how it saw fit

    Description

      When you enter HTML source mode, then switch to editor mode, Atto moves the code then cleans it. We should do it the other way around so the cleaning code can do its job before the DOM gets the code.

      Attachments

        Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-47003 Atto HTML cleaning is overly agressive and nonsensical

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-49565 Allow comments in Atto saved code

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              emerrill Eric Merrill
              emerrill Eric Merrill
              Andrew Lyons Andrew Lyons
              Dave Cooper Dave Cooper
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/May/15