Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49696

Removed YUI code still in thirdpartylibs.xml

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9
    • Fix Version/s: 2.9
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide
      1. Run the codechecker:

        php local/codechecker/run.php theme/bootstrapbase/
        

      2. Confirm that there were no fails related to YUI or thirdpartylibs

      (Sorry, it takes a rather long time to verify moodle.css)

      Show
      Run the codechecker: php local/codechecker/run.php theme/bootstrapbase/ Confirm that there were no fails related to YUI or thirdpartylibs (Sorry, it takes a rather long time to verify moodle.css)
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull Master Branch:
      MDL-49696-master

      Description

      MDL-49262 removed the YUI versions of the bootstrap plugins. The thirpartylibs.xml file in the bootstrapbase theme was not updated when they were removed:

      Processing /Applications/MAMP/htdocs/moodle29/theme/bootstrapbase/thirdpartylibs.xml for exclussions, incorrect /theme/bootstrapbase/yui/src/bootstrap/js/bootstrapcollapse.js path found. Please fix it

      line 216 of /local/codechecker/locallib.php: call to debugging()
      line 71 of /local/codechecker/index.php: call to local_codesniffer_get_ignores()

      Processing /Applications/MAMP/htdocs/moodle29/theme/bootstrapbase/thirdpartylibs.xml for exclussions, incorrect /theme/bootstrapbase/yui/src/bootstrap/js/bootstrapdropdown.js path found. Please fix it

      line 216 of /local/codechecker/locallib.php: call to debugging()
      line 71 of /local/codechecker/index.php: call to local_codesniffer_get_ignores()

      Processing /Applications/MAMP/htdocs/moodle29/theme/bootstrapbase/thirdpartylibs.xml for exclussions, incorrect /theme/bootstrapbase/yui/src/bootstrap/js/bootstrapengine.js path found. Please fix it

      line 216 of /local/codechecker/locallib.php: call to debugging()
      line 71 of /local/codechecker/index.php: call to local_codesniffer_get_ignores()

      To reporoduce, install local_codechecker and run it anywhere on the moodle code base.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/May/15