Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49743

Single view selecting "Choose..." causes errors to appear and bad page to load

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.7, 2.8.5, 2.9, 3.0.1, 3.1
    • Fix Version/s: 2.9.4, 3.0.2
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide

      There are two ways to reproduce this, one with JS off and one with use of back button:

      Setup:

      1. Create a course wth multiple students enrolled
      2. As teacher, Navigate to Course > Grade administration > Single view

      Non-JS replication:

      1. Disable JS
      2. On the dropdowns 'Select grade item' select no option and press 'Go'
      3. VERIFY: that php errors are not experienced and you just get the same page
      4. On the dropdowns 'Select user' select no option and press 'Go'
      5. VERIFY: that php errors are not experienced and you just get the same page

      JS replication:

      1. On the 'Select grade item' select, choose a grade item
      2. You should be redicted to that grade item's singleview
      3. Press your browser back button
      4. On the dropdown select the 'Select grade item' (i.e. don't choose a grade item)
      5. VERIFY: you do not get a php error.
      6. On the 'Select user' select, choose a user
      7. You should be redicted to that users singleview
      8. Press your browser back button
      9. On the dropdown select the 'Select user' option (i.e. don't choose a user)
      10. VERIFY: you do not get a php error.
      Show
      There are two ways to reproduce this, one with JS off and one with use of back button: Setup: Create a course wth multiple students enrolled As teacher, Navigate to Course > Grade administration > Single view Non-JS replication: Disable JS On the dropdowns 'Select grade item' select no option and press 'Go' VERIFY: that php errors are not experienced and you just get the same page On the dropdowns 'Select user' select no option and press 'Go' VERIFY: that php errors are not experienced and you just get the same page JS replication: On the 'Select grade item' select, choose a grade item You should be redicted to that grade item's singleview Press your browser back button On the dropdown select the 'Select grade item' (i.e. don't choose a grade item) VERIFY: you do not get a php error. On the 'Select user' select, choose a user You should be redicted to that users singleview Press your browser back button On the dropdown select the 'Select user' option (i.e. don't choose a user) VERIFY: you do not get a php error.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-49743-master
    • Pull Master Diff URL:

      Description

      To reproduce:
      Navigate to Single view.
      Select user or item.
      Once the page loads, use the browser's back button.
      Note that your selection appears in the dropdown as selected.
      In that dropdown, select "Choose...".

      If this is the user dropdown, the error log will be flooded as shown in the screenshot. If this is the item dropdown, a fatal error will occur.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jan/16