Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49754

Incorrect JSON in LTI Tool Settings service requests

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Prerequisites

      Install ngrok and run it ngrok http 80

      Test

      1. Configure an LTI tool registration for http://ltiapps.net/test/tp.php, offer it all capabilities and all services
      2. Register the new tool (Site administration ▶︎ Plugins ▶︎ Activity modules ▶︎ LTI ▶︎ Manage external tool registrations then click "Configure a new external tool registration") select all the capabilities and services
      3. Go to Site administration ▶︎ Plugins ▶︎ Activity modules ▶︎ LTI ▶︎ Manage external tool types and enable the Test tool provider tool type configured by the tool proxy received.
      4. Goto a course as a teacher and add an instance of this tool
      5. Launch the tool and click on the Tool Settings button
      6. Ensure the application/vnd.ims.lti.v2.toolsettings+json format option is selected
      7. Click the Read button
      8. The JSON returned should include an @id element at the top level of the @graph element(s) and also one within the custom element which is the same value but with a suffix of "/custom"
      Show
      Prerequisites Install ngrok and run it ngrok http 80 Test Configure an LTI tool registration for http://ltiapps.net/test/tp.php , offer it all capabilities and all services Register the new tool (Site administration ▶︎ Plugins ▶︎ Activity modules ▶︎ LTI ▶︎ Manage external tool registrations then click "Configure a new external tool registration") select all the capabilities and services Go to Site administration ▶︎ Plugins ▶︎ Activity modules ▶︎ LTI ▶︎ Manage external tool types and enable the Test tool provider tool type configured by the tool proxy received. Goto a course as a teacher and add an instance of this tool Launch the tool and click on the Tool Settings button Ensure the application/vnd.ims.lti.v2.toolsettings+json format option is selected Click the Read button The JSON returned should include an @id element at the top level of the @graph element(s) and also one within the custom element which is the same value but with a suffix of "/custom"
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-49754-master

      Description

      The JSON format used for the LTI Tool Settings service does not use the correct format as per the IMS spec. The @id element has the wrong value and is omitted from within the custom element. This issue only applies when using the application/vnd.ims.lti.v2.toolsettings+json format and not the application/vnd.ims.lti.v2.toolsettings.simple+json format.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              svickers Stephen Vickers
              Reporter:
              svickers Stephen Vickers
              Peer reviewer:
              John Okely
              Integrator:
              Dan Poltawski
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/May/16