Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49755

Read moodle_backup.xml only once during restore

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: 2.9
    • Component/s: Backup
    • Labels:
    • Testing Instructions:
      Hide

      1. Create a "Large" test course (Site Admin > Development > Make a test course.
      2. Backup the test course. (Be patient, it takes time for the screens to progress)
      3. Restore the test course. (Again screens are slow)
      4. Verify Course restored successfully (correct number of sections, pages still work).

      Restore time should be in a number of minutes, not a number of hours.

      Testing multiple restores in a single process should be completed as well, however I'm not sure how to create that scenario. Ideas?

      Show
      1. Create a "Large" test course (Site Admin > Development > Make a test course. 2. Backup the test course. (Be patient, it takes time for the screens to progress) 3. Restore the test course. (Again screens are slow) 4. Verify Course restored successfully (correct number of sections, pages still work). Restore time should be in a number of minutes, not a number of hours. Testing multiple restores in a single process should be completed as well, however I'm not sure how to create that scenario. Ideas?
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      When restoring complicated courses, backup_general_helper::get_backup_information() can be called many times. In the example of a Large example course the following happens

      Calls to get_backup_information 5546
      Time per call 4-5 seconds
      Restore Time 6.3 hours

      Caching get_backup_information can provide a significant performance improvement as much of the calculation of the restore is stored in memory.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mr-russ Russell Smith
              Reporter:
              mr-russ Russell Smith
              Peer reviewer:
              Eloy Lafuente (stronk7)
              Integrator:
              Dan Poltawski
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15