Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49776

lis_result_sourcedid should not always be included in launch

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Goto a course as a teacher
      2. Add an external tool type with a launch URL of http://lti.tools/test/tp.php, any key and a secret of "secret"
      3. Ensure the "Accept grades from the tool" privacy option is not ticked
      4. Save and display the tool
      5. Note that neither the lis_outcome_service_url nor the lis_result_sourcedid parameter is passed on launch
      6. Return to the course and edit the settings of the link and tick the "Accept grades from the tool" privacy option
      7. Save and display the tool
      8. Note that both the lis_outcome_service_url and the lis_result_sourcedid parameter are now passed on launch
      Show
      Goto a course as a teacher Add an external tool type with a launch URL of http://lti.tools/test/tp.php , any key and a secret of "secret" Ensure the "Accept grades from the tool" privacy option is not ticked Save and display the tool Note that neither the lis_outcome_service_url nor the lis_result_sourcedid parameter is passed on launch Return to the course and edit the settings of the link and tick the "Accept grades from the tool" privacy option Save and display the tool Note that both the lis_outcome_service_url and the lis_result_sourcedid parameter are now passed on launch
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-49776-master

      Description

      The lis_result_sourcedid identifies the cell in the gradebook associated with the current user and current launch link. If the "Accept grades from the tool" option is not selected no grades should be accepted for the link and so there is no point sending the lis_result_sourcedid parameter. A tool provider may already have the service endpoint from launches from other links and so attempt to access this gradebook column. Attempts to do so are denied, but the presence of the parameter is potentially confusing to a tool provider who may think that the service is available because it has been passed.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                6/Jul/15