Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49778

Update upgrade_stale_php_files_present() before 2.8.6 and 2.9 releases

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.5, 2.9
    • Fix Version/s: 2.9
    • Component/s: General, Installation
    • Labels:
    • Testing Instructions:
      Hide

      master

      1. Create and install a 2.8 installation.
      2. Check out a 2.9. Before upgrading, copy lib/timezone.txt from another 2.8 installation and put it in the the checked out 2.9 installation.
      3. Do a web based upgrade to 2.9.
      4. A notice should be displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release.
      5. Delete the timezone.txt file and refresh.
      6. Ensure that the upgrade now will proceed.

      2.8

      1. Create and install a 2.7 installation.
      2. Check out the latest 2.8. Before upgrading, copy course/delete_category_form.php from another 2.7 installation and put it in the the checked out 2.8 installation.
      3. Do a web based upgrade to 2.8.
      4. A notice should be displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release.
      5. Delete the delete_category_form.php file and refresh.
      6. Ensure that the upgrade now will proceed.
      Show
      master Create and install a 2.8 installation. Check out a 2.9. Before upgrading, copy lib/timezone.txt from another 2.8 installation and put it in the the checked out 2.9 installation. Do a web based upgrade to 2.9. A notice should be displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release. Delete the timezone.txt file and refresh. Ensure that the upgrade now will proceed. 2.8 Create and install a 2.7 installation. Check out the latest 2.8. Before upgrading, copy course/delete_category_form.php from another 2.7 installation and put it in the the checked out 2.8 installation. Do a web based upgrade to 2.8. A notice should be displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release. Delete the delete_category_form.php file and refresh. Ensure that the upgrade now will proceed.
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-49778-master

      Description

      Before every major release, we use to feed upgrade_stale_php_files_present() with files that don't belong anymore to core (and have zero chances to come back).

      It seems we have forgotten that for 2.8.0 and also, there are not 2.9.0 files there.

      While this is not critical, it helps to detect sites that are not running a pure, clean installation but a mix/copy over of files.

      So this is about to add a couple of files before we release 2.8.5 (files that were deleted before 2.8.0) and 2.9.0 (files that were deleted before 2.9.0).

      Simple, not critical, but still, interesting, IMO.

      Ciao

        Attachments

          Activity

            People

            Assignee:
            abgreeve Adrian Greeve
            Reporter:
            stronk7 Eloy Lafuente (stronk7)
            Peer reviewer:
            Simey Lameze
            Integrator:
            David Monllaó
            Tester:
            David Monllaó
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/May/15