Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49826

Single view ignores capability moodle/grade:edit and always requires moodle/grade:manage

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a course with at least 1 gradable item, 1 student enrolment and 1 teacher enrolment.
      2. Override the teacher role for that course, to prevent the capability 'moodle/grade:manage' (making sure the 'moodle/grade:edit' capability is still allowed)
      3. Log in as the teacher user
      4. Visit the course grades page + select the 'Single view' grade report
      5. Select the student user (from the drop down) and override the grade for the activity
      6. * Make sure the overridden grade can be saved
      7. Select the gradable activity (from the drop down) and override the grade again
      8. * Make sure the overridden grade can be saved

      (For completeness, the 'perform bulk insert option could be tested as well).

      1. Change the teacher role again, add 'manage' but remove 'edit'. Make sure the grading interface is consistent for grader report and single view (the later should not be available if the user is missing edit capability, neither in dropdown, neither from navigation, neither from links in the grader report, neither from elsewhere)
      Show
      Create a course with at least 1 gradable item, 1 student enrolment and 1 teacher enrolment. Override the teacher role for that course, to prevent the capability 'moodle/grade:manage' (making sure the 'moodle/grade:edit' capability is still allowed) Log in as the teacher user Visit the course grades page + select the 'Single view' grade report Select the student user (from the drop down) and override the grade for the activity * Make sure the overridden grade can be saved Select the gradable activity (from the drop down) and override the grade again * Make sure the overridden grade can be saved (For completeness, the 'perform bulk insert option could be tested as well). Change the teacher role again, add 'manage' but remove 'edit'. Make sure the grading interface is consistent for grader report and single view (the later should not be available if the user is missing edit capability, neither in dropdown, neither from navigation, neither from links in the grader report, neither from elsewhere)
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull Master Branch:
      MDL-49826_grade_single_view

      Description

      The Gradebook 'grader' requires the "moodle/grade:edit" capability so users can edit students grades. The capability "moodle/grade:manage" is only required to modify some advanced options in grades: excluded, hidden or locked.

      In the other side, the new functionality "Single View" requires only the "moodle/grade:manage" capability to realize all operations: grade, override or exclude.

      This drives to an inconsistence. In a specific scenario, we may want a user (maybe a non-editing teacher) only assigning grade to activities but not managing them.

      Maybe we can improve "Single view" to adequate the required capability accordingly to desired operation like 'grader' (for example: disabling the excluded checkbox if user don't have "moodle/grade:manage" capability).

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                3 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Sep/15