[MDL-49837] Fix mod_assign external function tests (missing return parameters cleaning and invalid checks) - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.8
Fix Version/s: 2.7.8, 2.8.6
Component/s: Web Services
Labels:
- triaged

Affected Branches:
MOODLE_28_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Pull from Repository:
git://github.com/jleyva/moodle.git
Pull Master Branch:
~~MDL-49837~~-master
Pull Master Diff URL:
https://github.com/jleyva/moodle/compare/d755125...MDL-49837-master
Testing Instructions:

Hide

The only way for test this is just to run phpunit for mod/assign/tests/externallib_test.php

Show
The only way for test this is just to run phpunit for mod/assign/tests/externallib_test.php

Description

Some of the mod_assign external function tests are missing the return parameters cleaning and they are doing invalid checks, also in some functions the warning structure is returned incorrectly

Attachments

Issue Links

Discovered while testing

MDL-45131 Some external functions tests don't validate returned parameters

Closed

Activity

People

Assignee:: Juan Leyva

Reporter:: Juan Leyva

Peer reviewer:: Dani Palou

Integrator:: Dan Poltawski

Tester:: CiBoT

Participants:: CiBoT, Dani Palou, Dan Poltawski, Juan Leyva, Rajesh Taneja

Component watchers:: Juan Leyva, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 14/Apr/15 6:55 AM

Updated:: 18/Apr/15 3:54 AM

Resolved:: 18/Apr/15 3:54 AM

Fix Release Date:: 11/May/15