Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49864

All PDF Pen annotations are invisible (when viewed online) if there are draft pen annotations

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Testing Instructions

      • Part 1: As admin, create a course and an assignment
        1. Login as an administrator.
        2. Create a course and enrol participants.
        3. Under Course Administration, click "Turn editing on".
        4. Click "Add an activity or resource"
        5. Select "Assignment", then click "Add"
        6. Enter a value under "Assignment name"
        7. Under "Submission types", check "File submissions".
        8. Under "Grade", set "Use marking workflow" to "Yes".
        9. Click "Save and display".
        10. Log out.
      • Part 2: As student, submit a PDF file for the assignment
        1. Login as a student.
        2. Click on the course link.
        3. Click on the created assignment.
        4. Click on "Add submission"
        5. Attach a PDF file and click "Save changes"
      • Part 3: As teacher (or higher), annotate the PDF
        1. Login as a teacher (or higher).
        2. Click on the course link.
        3. Click on the assignment.
        4. Click "View/grade all submissions"
        5. Click on the "Grade" icon (or "Edit" -> "Grade") for the student with the submission.
        6. In the "Grade" section, click "Launch PDF editor..."
        7. Add a comment box and draw something with the pen tool and/or add a stamp.
        8. Exit the PDF editor.
        9. Set the "Marking workflow state" as "Released".
        10. Click "Save changes" and click "Continue"
        11. Back on the Grading page, click again on the Grade icon for the same student.
        12. Click "Launch PDF editor..."
        13. Add another comment box and draw something with the pen tool and/or add a stamp.
        14. Exit the PDF editor.
        15. This time, click "Cancel"
        16. Back on the Grading page, under the "Annotate PDF" column, click on the annotated PDF link to download the annotated PDF file.
        17. Click on the "View annotated PDF..." button.
        18. Compare the downloaded PDF file with the one on the "Annotate PDF" window.
      • Part 4: As a student, check the annotated PDF
        1. Login as a student.
        2. Click on the course link.
        3. Click on the assignment.
        4. Under the Feedback section, click on the annotated PDF link to download the annotated PDF file.
        5. Click on the "View annotated PDF..." button.
        6. Compare the downloaded PDF file with the one on the "Annotate PDF" window.
      • Part 5: Check the draft PDF
        1. As a teacher (or higher) on the Grading page, continue grading the same student.
        2. Click "Launch PDF editor..."

      Expected Results

      • For Part 3, the downloaded PDF file and the PDF in the "Annotate PDF" window should look the same without the draft comments and annotations.
      • For Part 4, the downloaded PDF file and the PDF in the "Annotate PDF" window should look the same without the draft comments and annotations.
      • For Part 5, the "Annotate PDF" window should show the draft and non-draft comments and annotations.
      Show
      Testing Instructions Part 1: As admin, create a course and an assignment Login as an administrator. Create a course and enrol participants. Under Course Administration, click "Turn editing on". Click "Add an activity or resource" Select "Assignment", then click "Add" Enter a value under "Assignment name" Under "Submission types", check "File submissions". Under "Grade", set "Use marking workflow" to "Yes". Click "Save and display". Log out. Part 2: As student, submit a PDF file for the assignment Login as a student. Click on the course link. Click on the created assignment. Click on "Add submission" Attach a PDF file and click "Save changes" Part 3: As teacher (or higher), annotate the PDF Login as a teacher (or higher). Click on the course link. Click on the assignment. Click "View/grade all submissions" Click on the "Grade" icon (or "Edit" -> "Grade") for the student with the submission. In the "Grade" section, click "Launch PDF editor..." Add a comment box and draw something with the pen tool and/or add a stamp. Exit the PDF editor. Set the "Marking workflow state" as "Released". Click "Save changes" and click "Continue" Back on the Grading page, click again on the Grade icon for the same student. Click "Launch PDF editor..." Add another comment box and draw something with the pen tool and/or add a stamp. Exit the PDF editor. This time, click "Cancel" Back on the Grading page, under the "Annotate PDF" column, click on the annotated PDF link to download the annotated PDF file. Click on the "View annotated PDF..." button. Compare the downloaded PDF file with the one on the "Annotate PDF" window. Part 4: As a student, check the annotated PDF Login as a student. Click on the course link. Click on the assignment. Under the Feedback section, click on the annotated PDF link to download the annotated PDF file. Click on the "View annotated PDF..." button. Compare the downloaded PDF file with the one on the "Annotate PDF" window. Part 5: Check the draft PDF As a teacher (or higher) on the Grading page, continue grading the same student. Click "Launch PDF editor..." Expected Results For Part 3, the downloaded PDF file and the PDF in the "Annotate PDF" window should look the same without the draft comments and annotations. For Part 4, the downloaded PDF file and the PDF in the "Annotate PDF" window should look the same without the draft comments and annotations. For Part 5, the "Annotate PDF" window should show the draft and non-draft comments and annotations.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull Master Branch:
      MDL-49864-master
    • Sprint:
      Team '; drop tables Sprint 9

      Description

      I have discovered a bug where a student viewing an annotated PDF from within the online Moodle viewer, where the annotated PDF has unsaved pen annotation, cannot see any pen annotation (both previously saved and draft). However when downloading the annotated PDF file from Moodle, the annotations are shown correctly (the previously saved pen annotations are visible, but the draft are not).

      This issue does not affect comment boxes. Previously saved comment boxes are always visible , regardless of the draft status of other comment boxes.

      This issue is present when viewed as a student from the gradebook or a tutor/non-primary lecturer/etc from the list of students to grade (mod/assign/view.php?id=xxx&action=grading)

      I have reproduced this bug consistently on both Moodle 2.7 and 2.8

      Steps to reproduce:

      1. Create an assignment activity where students are allowed to submit a file and the marking workflow is enabled
      2. As a student, submit a PDF file for the assignment
      3. As a tutor (or higher), begin grading the assignment.
      4. From the grading page, click "Launch PDF editor" to begin annotating the PDF
      5. Add a comment box and draw something with the pen tool
      6. Exit the PDF editor and click "save changes"
      7. For the same student, continue grading the assignment and launch the PDF editing tool.
      8. Add another comment box and draw some more with the pen tool
      9. Exit the PDF editor
      10. Either:
        • Click the browser back button
        • Click the "Cancel" button at the bottom of the page
      11. While viewing all submitted assignments (not the page for grading the individual student), select the entry for the student and use "with selected" drop down box to select "set marking workflow state", the click the "Go" button.
      12. Changed the marking workflow state to "released"
      13. As the student, visit the gradebook and view the feedback for your assignment.
      14. Click the "View annotated PDF" button. You will see:
        • The first comment box (which was saved) but not the second comment box (which is still in draft state). This is the correct behaviour
        • No pen annotation is visible, despite the fact that some should be in the draft state (thus invisible), while some was explicitly saved (this should be visible). This is incorrect behaviour.
      15. Close the PDF viewer and download the annotated PDF from the link provided.
      16. Open the downloaded PDF file, you will see all of the non-draft content as expected.

        Attachments

          Activity

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/15