Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49869

Consolidate Mustache loader logic between Ajax and core renderers

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:

      Description

      I noticed the following issues while working on MDL-49800.

      1. The output/external.php logic partially duplicates the code from renderer_base::get_mustache()
      2. output/external.php is not using mustache_filesystem_loader()
      3. output/external.php does not support subtypes
      4. I am not sure how subtypes are supposed to work, but I don't think their directory will be correct in renderer_base::get_mustache() as core_component::get_component_directory('mod_assign_subtype') is an invalid component.
      5. Add tests.

      We should have a standardised way to get mustache to resolve the templates for us. Whether from outputrenderers, or from Ajax, or anywhere else.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: