Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49932

Upgraded sites get defaulthomepage changed to HOMEPAGE_MY unconditionally

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Blocker Blocker
    • 2.9
    • 2.9
    • Navigation
    • MOODLE_29_STABLE
    • MOODLE_29_STABLE
    • MDL-49932_master
    • Hide
      1. Install a clean 28 site
      2. Upgrade to latest master
      3. Perform "git log --grep="MDL-49932"" and confirm the commit was included.
      4. Complete the upgrade and verify that the default for defaulthomepage == HOMEPAGE_SITE
      Show
      Install a clean 28 site Upgrade to latest master Perform "git log --grep=" MDL-49932 "" and confirm the commit was included. Complete the upgrade and verify that the default for defaulthomepage == HOMEPAGE_SITE
    • Team Beards Sprint 6

      It seems that recently we have added an unconditional upgrade script causing all existing sites to change their default behavior from defaulthomepage = HOMEPAGE_SITE to HOMEPAGE_MY. See (part of 5472f9f4e, belonging to MDL-45774):

      https://github.com/moodle/moodle/blob/master/lib/db/upgrade.php#L4340

      And that's incorrect. Existing sites should not get their previous behavior changed. NP with new sites if documented. That was achieved (correctly) by MDL-49630. See:

      https://github.com/moodle/moodle/commit/9e2b644

      So, while the later is 100% the expected behavior (apply new default for new sites, keeping existing ones unmodified)... the upgrade step above destroyed it causing upgraded sites to change their behavior.

      Not sure if that was discussed at some point, but IMO it's simply incorrect/opposed to our usual BC rules, leading to confusion, hence reporting it.

      Ciao

            markn Mark Nelson
            stronk7 Eloy Lafuente (stronk7)
            Damyon Wiese Damyon Wiese
            Andrew Lyons Andrew Lyons
            Rajesh Taneja Rajesh Taneja
            Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.