Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49932

Upgraded sites get defaulthomepage changed to HOMEPAGE_MY unconditionally

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.9
    • Fix Version/s: 2.9
    • Component/s: Navigation
    • Labels:
    • Testing Instructions:
      Hide
      1. Install a clean 28 site
      2. Upgrade to latest master
      3. Perform "git log --grep="MDL-49932"" and confirm the commit was included.
      4. Complete the upgrade and verify that the default for defaulthomepage == HOMEPAGE_SITE
      Show
      Install a clean 28 site Upgrade to latest master Perform "git log --grep=" MDL-49932 "" and confirm the commit was included. Complete the upgrade and verify that the default for defaulthomepage == HOMEPAGE_SITE
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-49932_master
    • Sprint:
      Team Beards Sprint 6

      Description

      It seems that recently we have added an unconditional upgrade script causing all existing sites to change their default behavior from defaulthomepage = HOMEPAGE_SITE to HOMEPAGE_MY. See (part of 5472f9f4e, belonging to MDL-45774):

      https://github.com/moodle/moodle/blob/master/lib/db/upgrade.php#L4340

      And that's incorrect. Existing sites should not get their previous behavior changed. NP with new sites if documented. That was achieved (correctly) by MDL-49630. See:

      https://github.com/moodle/moodle/commit/9e2b644

      So, while the later is 100% the expected behavior (apply new default for new sites, keeping existing ones unmodified)... the upgrade step above destroyed it causing upgraded sites to change their behavior.

      Not sure if that was discussed at some point, but IMO it's simply incorrect/opposed to our usual BC rules, leading to confusion, hence reporting it.

      Ciao

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/May/15