Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49953

enrol_cohort_create_new_group does not check courseid

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a cohort (i.e. "People") and two courses
      2. in courses as admin create instances of cohort enrolment linking to "People", select "Create new group"
      3. Make sure that in the both courses the automatically created group is called "People cohort" and does not have any increments in the end
      4. Create another course and create "People cohort" group inside it (empty).
      5. Add instance of cohort enrolment and select "Create new group".
      6. Make sure the grou "People cohort (2)" was cretaed and populated with users (if there were any in the cohort)
      Show
      Create a cohort (i.e. "People") and two courses in courses as admin create instances of cohort enrolment linking to "People", select "Create new group" Make sure that in the both courses the automatically created group is called "People cohort" and does not have any increments in the end Create another course and create "People cohort" group inside it (empty). Add instance of cohort enrolment and select "Create new group". Make sure the grou "People cohort (2)" was cretaed and populated with users (if there were any in the cohort)
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull Master Branch:
      wip-MDL-49953-master

      Description

      This was noticed on MDL-17929 by Eloy Lafuente (stronk7) (see comment), but the code there was copy-pasted from the function enrol_cohort_create_new_group() introduced in issue MDL-49380

      When looking for existing group we look globally instead of within the given course.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              David Monllaó
              Integrator:
              Dan Poltawski
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15