Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-49954

Incorrect use of clean_returnvalue in forum externallib tests

    XMLWordPrintable

Details

    Description

      Example:

              $discussions = mod_forum_external::get_forum_discussions(array($forum1->id, $forum2->id));
              external_api::clean_returnvalue(mod_forum_external::get_forum_discussions_returns(), $discussions);
      

      The clean_returnvalue returns the result cleaned, in this case the function return should be assigned to $discussions

      Note that this issue is different than MDL-45131 (here, the functions were missing the clean_returnvalue)

      Attachments

        Activity

          People

            jleyva Juan Leyva
            jleyva Juan Leyva
            Dani Palou Dani Palou
            David Monllaó David Monllaó
            CiBoT CiBoT
            Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo, Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              11/May/15